Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add import React statement in JSX file example #7050

Merged
merged 1 commit into from
Mar 29, 2022
Merged

docs: add import React statement in JSX file example #7050

merged 1 commit into from
Mar 29, 2022

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented Mar 29, 2022

Motivation

Reduce odds that React + TypeScript newbies like me file issues on your repo

Have you read the Contributing Guidelines on pull requests?

👍

Test Plan

None.

Related PRs

None.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 29, 2022
@Josh-Cena Josh-Cena changed the title Fix #7047 by adding React import statement docs: add import React statement in JSX file Mar 29, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 29, 2022
@Josh-Cena Josh-Cena changed the title docs: add import React statement in JSX file docs: add import React statement in JSX file example Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a63642
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62425f4ae0526f0008789044
😎 Deploy Preview https://deploy-preview-7050--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7050--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

It's certainly much less confusing :)

@Josh-Cena Josh-Cena merged commit e31e91e into facebook:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants