Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add firelordjs to showcase #7024

Closed
wants to merge 5 commits into from
Closed

docs: add firelordjs to showcase #7024

wants to merge 5 commits into from

Conversation

tylim88
Copy link
Contributor

@tylim88 tylim88 commented Mar 26, 2022

Motivation

open source contribution

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No

Related PRs

No

@facebook-github-bot
Copy link
Contributor

Hi @tylim88!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify
Copy link

netlify bot commented Mar 26, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 986040a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6241d58c521cfa0009073570
😎 Deploy Preview https://deploy-preview-7024--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 26, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 50
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7024--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 26, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 27, 2022
@Josh-Cena
Copy link
Collaborator

@tylim88 The CLA isn't coming through. Could you double-check the CLA status?

@Josh-Cena Josh-Cena removed the CLA Signed Signed Facebook CLA label Mar 28, 2022
@tylim88
Copy link
Contributor Author

tylim88 commented Mar 28, 2022

@Josh-Cena
image

I re-signed the CLA just now

how can I check the status?

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2022
@tylim88
Copy link
Contributor Author

tylim88 commented Mar 29, 2022

is this PR ok or do I need to open a new one?

@Josh-Cena
Copy link
Collaborator

@tylim88 If you can open a new PR based on this branch (because I made commits as well) it would be great. It seems the CLA bot is stuck somewhere. Thanks a lot!

@tylim88
Copy link
Contributor Author

tylim88 commented Mar 29, 2022

ok I will update the change and open the new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA closed: duplicate This issue or pull request already exists in another issue or pull request pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants