Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content-docs): warn when files are not tracked #6937

Merged
merged 7 commits into from
Mar 21, 2022
Merged

fix(content-docs): warn when files are not tracked #6937

merged 7 commits into from
Mar 21, 2022

Conversation

felipecrs
Copy link
Contributor

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 18, 2022
@felipecrs
Copy link
Contributor Author

@Josh-Cena there are some changes here related to devcontainer configuration. Please let me know if you would like me to detach them from this PR.

@netlify
Copy link

netlify bot commented Mar 18, 2022 •
edited
Loading

✅ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 9d4ada7

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/623766f43c3c580008be75d6

😎 Browse the preview: https://deploy-preview-6937--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 18, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 42
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6937--docusaurus-2.netlify.app/

@felipecrs
Copy link
Contributor Author

felipecrs commented Mar 18, 2022 •
edited
Loading

Ref: jest-community/vscode-jest#846

Josh-Cena
Josh-Cena reviewed Mar 19, 2022
View reviewed changes
jest.config.mjs Show resolved Hide resolved
.cspell.json Outdated Show resolved Hide resolved
packages/docusaurus-utils/src/gitUtils.ts Outdated Show resolved Hide resolved
packages/docusaurus-utils/src/gitUtils.ts Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena changed the title fix(docs): warn when files are not tracked fix(content-docs): warn when files are not tracked Mar 19, 2022
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 19, 2022
@felipecrs felipecrs requested a review from Josh-Cena March 20, 2022 17:40
Josh-Cena
Josh-Cena approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks great!

@Josh-Cena
Copy link
Collaborator

BTW, it's great that we have people developing with dev containers/vscode jest extensions, etc. I've personally never figured out how that worked so I just have it disabled😅 If you want to write some contributing guides, or improve our infrastructure around that, it would be great!

@Josh-Cena Josh-Cena merged commit e19a4e2 into facebook:main Mar 21, 2022
@felipecrs felipecrs deleted the err-to-warn branch March 21, 2022 02:10
@slorber slorber mentioned this pull request Mar 23, 2022
Closed
@felipecrs felipecrs mentioned this pull request Mar 23, 2022
Merged
@felipecrs felipecrs mentioned this pull request Apr 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber slorber left review comments

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felipecrs @Josh-Cena @slorber @facebook-github-bot