-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme-classic): little breadcrumbs improvements #6932
Conversation
|
||
@media (min-width: 997px) { | ||
.breadcrumbsItemLink { | ||
--ifm-breadcrumb-size-multiplier: 0.8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it dead code right now, or should the breadcrumb items size be bigger on desktop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 I don't remember, but that looks fine to remove it 👍
✔️ [V2] 🔨 Explore the source changes: 679f91b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/62336f7ddc415c0008a14e65 😎 Browse the preview: https://deploy-preview-6932--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6932--docusaurus-2.netlify.app/ |
Size Change: -247 B (0%) Total Size: 792 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before:
After:
I don't have a strong opinion on this, both look fine to me 👍
Wonder if the icon size change was on purpose? Maybe it's a bit too small now?
Also wondering if the :hover effect on the breadcrumb item shouldn't be disabled if the category has no link?
cf:
https://deploy-preview-6932--docusaurus-2.netlify.app/docs/migration/automated/
|
||
@media (min-width: 997px) { | ||
.breadcrumbsItemLink { | ||
--ifm-breadcrumb-size-multiplier: 0.8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 I don't remember, but that looks fine to remove it 👍
I would use 0.8 multiplier, so yes, maybe worth to increase by 0.1 for all devices.
Don't think so, the active state should be the same whether item is a link or not. |
👍 |
Motivation
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs