Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve client modules types #6742

Merged
merged 1 commit into from
Feb 23, 2022
Merged

refactor: improve client modules types #6742

merged 1 commit into from
Feb 23, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

To make the diff of #6732 less confusing

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 23, 2022
@netlify
Copy link

netlify bot commented Feb 23, 2022

✔️ [V2]

🔨 Explore the source changes: 29e9e31

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6215e21575c7d30007d3db07

😎 Browse the preview: https://deploy-preview-6742--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 45
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6742--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -3 B (0%)

Total Size: 781 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 48 kB 0 B
website/build/assets/css/styles.********.css 106 kB 0 B
website/build/assets/js/main.********.js 590 kB -3 B (0%)
website/build/index.html 37.6 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit ddad971 into main Feb 23, 2022
@Josh-Cena Josh-Cena deleted the jc/client-module branch February 23, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants