Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Dime.Scheduler SDK to showcase #6001

Merged
merged 4 commits into from
Nov 24, 2021
Merged

docs: add Dime.Scheduler SDK to showcase #6001

merged 4 commits into from
Nov 24, 2021

Conversation

hbulens
Copy link
Contributor

@hbulens hbulens commented Nov 24, 2021

Motivation

Add the docs for the Dime.Scheduler SDK to the showcase page.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run the app and see if the page renders correctly with a new showcase entry.

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 24, 2021
@Josh-Cena Josh-Cena changed the title Add Dime.Scheduler SDK to showcase page docs: add Dime.Scheduler SDK to showcase Nov 24, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 24, 2021
@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 8f8d8fb

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619e14a29e7e610007ad1402

😎 Browse the preview: https://deploy-preview-6001--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 24, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6001--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You can't have both the opensource tag and source: null—maybe remove that tag?

Also, slightly unrelated but your site's fonts did not load on my computer:

image

If you want to use unconventional fonts remember to provide it as static asset or provide a nice fallback

@hbulens hbulens requested a review from Josh-Cena November 24, 2021 10:34
@Josh-Cena
Copy link
Collaborator

LGTM👍

@Josh-Cena Josh-Cena merged commit c916d8a into facebook:main Nov 24, 2021
slorber pushed a commit that referenced this pull request Nov 24, 2021
* Add Dime.Scheduler SDK to showcase page

* Add source URL to showcase

Co-authored-by: Josh-Cena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants