Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix BrowserOnly return statement #5953

Merged

Conversation

MorookaKotaro
Copy link
Contributor

Motivation

Missed return statement at BrowserOnly component

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

None

Related PRs

None

@netlify
Copy link

netlify bot commented Nov 15, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 5574303

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61925e9b1b6be8000747f368

😎 Browse the preview: https://deploy-preview-5953--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 15, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5953--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we already fixed this in the next docs (#5881) but it makes sense to port it to versioned docs

@Josh-Cena Josh-Cena merged commit 284cdab into facebook:main Nov 15, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 15, 2021
@MorookaKotaro MorookaKotaro deleted the morookakotaro/fix-browsreonly-return branch November 15, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants