Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-pwa): migrate package to TS #5941

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 13, 2021

Motivation

#5817

Have you read the Contributing Guidelines on pull requests?

yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2021
@netlify
Copy link

netlify bot commented Nov 13, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: ff4ce59

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6190a519f5a83800077cec1d

😎 Browse the preview: https://deploy-preview-5941--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 13, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5941--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added status: blocked This issue is blocked by another issue or external dep and can't be pushed further. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Nov 14, 2021
@slorber
Copy link
Collaborator

slorber commented Nov 16, 2021

awesome 👍 thanks again

@slorber slorber merged commit 85fcd9e into facebook:main Nov 16, 2021
@armano2 armano2 deleted the refactor/pwa branch November 16, 2021 19:42
@Josh-Cena Josh-Cena removed the status: blocked This issue is blocked by another issue or external dep and can't be pushed further. label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants