-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Node 17 #5814
feat: Support Node 17 #5814
Conversation
Size Change: +7 B (0%) Total Size: 847 kB ℹ️ View Unchanged
|
✔️ [V2] 🔨 Explore the source changes: cfeb69d 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617c0e06cb45900007652c36 😎 Browse the preview: https://deploy-preview-5814--docusaurus-2.netlify.app |
Hmmm this is more complex as Webpack uses some hashes in prod in multiple places. And it seems they plan to backport a MD4 hash impl here to fix the problem: webpack/webpack#14584 so it's probably not useful to change the hash algo for now |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5814--docusaurus-2.netlify.app/ |
Thanks @alexander-akait seems to be working :) |
@slorber Anyway, can you explain why |
@alexander-akait it's probably a lack of time/priority, I didn't work on it since last time. Also not sure how to do this migration without using a |
hm, I see... yes need may have to experiment or enter a new option... |
Motivation
Docusaurus should run on Node 17
Change filename hash algo
https://webpack.js.org/configuration/output/#outputhashfunction
Fixes #5778
Note: it's not too important to use md5 in the file-loader because it's deprecated and using an older version of loader-utils (does not allow using
xxhash64
).Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
CI