-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: npm init docusaurus, yarn create docusaurus #5635
Conversation
✔️ [V2] 🔨 Explore the source changes: 1c68910 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/615736ef5cf7750008d17785 😎 Browse the preview: https://deploy-preview-5635--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5635--docusaurus-2.netlify.app/ |
Size Change: +707 B (0%) Total Size: 834 kB
ℹ️ View Unchanged
|
✔️ [V2] 🔨 Explore the source changes: 8186a50 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/615efd2c1bfe5200070b12a5 😎 Browse the preview: https://deploy-preview-5635--docusaurus-2.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great idea!
"name": "@docusaurus/init", | ||
"version": "2.0.0-beta.6", | ||
"name": "create-docusaurus", | ||
"version": "0.0.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why "0.0.6"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Just because I did some test publish attempt to make sure it works and wanted to keep the ability to increment if needed
This will be fixed on next release by lerna so it doesn't matter
…d yarn result fails to execute
Reverting |
Motivation
Our init command is complex to type / remember:
Using the package name
create-docusaurus
and{isDefault: true}
allows to simplify it greatly:npx create-docusaurus
also worksAs this package is outside of
@docusaurus
org, I assigned proper roles on npm to the existing team.Unfortunately, we need to keep
@latest
due to npm: npm/cli#3821Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
init tests + e2e CI tests