Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-debug): migrate package to TypeScript #5465

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Another effort to get rid of AnyScript code in the repo.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview & CI

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 2, 2021
@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 3656e5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61309de978d83400085a99e3

😎 Browse the preview: https://deploy-preview-5465--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5465--docusaurus-2.netlify.app/

Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
@slorber
Copy link
Collaborator

slorber commented Sep 2, 2021

Thanks 👍 we're not far to have all plugins in TS :)

@slorber slorber merged commit 6b7f3e8 into facebook:main Sep 2, 2021
@Josh-Cena Josh-Cena deleted the ts-plugin-debug branch September 2, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants