Revert yarn prettier addition in yarn ci-check #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yangshun Can't tell whether the prettier test is failing because it didn't pick up your prettier changes or if there is something missing in your prettier changes. |
|
Sorry about that, I'm not on my home computer so I just made the changes using GitHub's inline code editor which means I wasn't able to run |
|
@JoelMarcey It was my mistake 😅 Have fixed it and the tests pass! |
JoelMarcey
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Revert the incorrect addition of
yarn prettiertoyarn ci-checkin #516 and run Prettier on the code base.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Let CI run
Related PRs
#516