-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mdx-loader): migrate package to TypeScript #5347
Conversation
✔️ [V2] 🔨 Explore the source changes: 969b45c 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6114af39a1dce40008e83f85 😎 Browse the preview: https://deploy-preview-5347--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5347--docusaurus-2.netlify.app/ |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5347--docusaurus-2.netlify.app/ |
✔️ [V2] 🔨 Explore the source changes: 7bf3766 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611504c56dac1a00072be541 😎 Browse the preview: https://deploy-preview-5347--docusaurus-2.netlify.app |
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
Signed-off-by: Josh-Cena <[email protected]>
b191e22
to
7bf3766
Compare
Thanks, LGTM |
Motivation
Following discussion with @slorber, migrated
mdx-loader
to TS for better type checks and hints.Have you read the Contributing Guidelines on pull requests?
Yea
Test Plan
Unit tests