-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: author/image adjustments in BlogPosting schema #5346
Conversation
✔️ [V2] 🔨 Explore the source changes: 0de9a31 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61146421838a110008bbd9d2 😎 Browse the preview: https://deploy-preview-5346--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5346--docusaurus-2.netlify.app/ |
Size Change: +15 B (0%) Total Size: 793 kB ℹ️ View Unchanged
|
👍 thanks |
@slorber just found out, we can annotate existent HTML markup to following BlogPosting schema, then we won't need to use JSON-LD. What do you think of this? https://orbitingweb.com/blog/schema-org-microdata-guide/ |
This might make the structured data more maintainable and avoid using duplicate conditional logic? Not sure we have this case on the blog posts, but how does it work when 2 structured data entities markup get interleaved in the HTML markup? Does it lead to the exact same SEO outcome? That's worth attempting a refactor @johnnyreilly any opinion? |
There shouldn't be a problem with this, since there is microdata for blog lists.
Yes, and moreover we get rid of duplicated data in separated comp. I'll see to this, maybe it will work out. |
Motivation
Just small fixes in BlogPosting schema after merge #5322:
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
Results for
blog/2021/05/12/announcing-docusaurus-two-beta
:Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)