-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): transpile libs with too recent syntax with babel #4789
Conversation
[V1] Built with commit 0410466 |
[V2] Built with commit 0410466 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4789--docusaurus-2.netlify.app/ |
Size Change: -31 B (0%) Total Size: 660 kB
ℹ️ View Unchanged
|
works on Edge 18 now |
Unknown if this is related, but when updating from docusaurus 2.0.0-beta.0 to 2.0.0-beta.1, I get this with
@echarles got a similar error in #5142 Not sure if this is related to my personal configuration, changes to webpack, this PR, or somewhere else. There's a lot of action going on edit: Narrow it down from beta 0 -> beta 3 to beta 0 -> beta 1 |
@tony without repro I can't do anything |
@slorber no problem. If I narrow it down I'll make an issue |
Motivation
Some libs (many from Sindre Sorhus) use too recent ES syntax and should be transpiled with Babel
copy-text-to-clipboard contains
try {} catch {}
for exampleNot doing this means we have some older browsers (like Edge 18 released in nov 2018) not supported while it could easily.
Noticed this while testing browser support of Docusaurus in #4766
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview + inspecting JS output + testing on Edge 18