feat(v2): default theme translations: locale "pt" should load "pt-BR" translations #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Built with commit 61cc0c3 |
|
[V2] Built with commit 61cc0c3 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4581--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 576 kB ℹ️ View Unchanged
|
|
[V1] Built with commit b814d70 |
|
[V2] Built with commit b814d70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using Docusaurus with locale "pt", we should try to load theme translations from "pt" and fallback to "pt-BR" (not "pt-PT"!)
"pt-BR" is more widely used than "pt-PT" and it's part of the unicode CLDR.
It's also encoded into the Intl APIs that we use in this PR (note, there's no TS support but it is supported in Node)
Refs:
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Tests