-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add tag filters to showcase page #4515
feat(v2): add tag filters to showcase page #4515
Conversation
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[V1] Built with commit 7c6c060 |
[V2] Built with commit 7c6c060 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4515--docusaurus-2.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
that's the idea but you should use React state and embrace the React way of doing things ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lisa761 I'm completing this PR and going to merge it tomorrow, please don't add new commits |
Motivation
closes #4238
Have you read the Contributing Guidelines on pull requests?
Yes
Additional Information
Right now, I am trying to update the sites rendered by using
filteredUsers = users.filter((user) => user.tags.includes(selectedTags))
.But this does not seem to work as
includes
is only defined on arrays, and althoughuser.tags
is an array in user.js it appears to be treated as an object inside thefilter
function.There are two ways to go about this:
includes
Let me know if any of these work or if there is another better way to go about this.