-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): upgrade dependencies #4148
Conversation
[V1] Deploy preview success Built with commit d8c8ba1 |
Deploy preview for docusaurus-2 ready! Built with commit d8c8ba1 |
After the last similar update in #3727, bundles size was 2.34 MB, but now more than 5 MB. Is this because the large docs files were split into multiple files? I see that as a result we have a lot of code duplication, can we somehow fix it? |
Size Change: 0 B Total Size: 28.8 kB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4148--docusaurus-2.netlify.app/classic/ |
de79012
to
0e6bca9
Compare
0e6bca9
to
d8c8ba1
Compare
How do you track that? Inspecting network requests on homepage / docs I don't see a significant increase |
With |
I see, you mean this? I don't think it's a problem, and yes it's likely related to splitting some docs as separate pages instead of having one page. I don't think it's too important to monitor the total amount of JS produced (as long as it remains relatively small) but more important to monitor the size of the main/runtime bundles that are loaded for the whole site. Not totally satisfied with the tooling we currently have to monitor and detect perf regressions, there's room for improvements here. I think we could add the bundle analyzer by default on deploy previews and maybe also track perf metrics with an external tool (suggested that already but need some validation) |
Yes, but I assumed that we would have one bundle with common dependencies. which is shared by other pages, is it possible to do something similar? |
Motivation
Another big upgrading of our deps.
There is a slight decrease in all website bundles from 5.18 MB to 5.15 MB.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Starting dev server and building website works correctly (tested with this script)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)