Fix build on Windows #381
Fix build on Windows #381
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@qcz Awesome. This is the type of small change I would like to at least get buildable on Windows. I want some variant of #360 as well -- but I would like that to be more of a pure refactor rather than a big bug fix as well. I would like to test this on some of our core sites outside of Windows too - docusuarus.io, for example. If those look, good we can merge this. Longer term, we should think about adding both Windows and linux/unix-based systems to our testing. |
|
Did some testing. I think this is good. Thanks so much! |
Motivation
I've fixed the build errors on Windows on my local instance, but I've been waiting for #360 to be merged so I can use this package on a build server. As I see that it may be further delayed because of the huge amount of changes I created a small PR with the Windows build fixes which may be merged in a bugfix release.
Test Plan
yarn testtests passed on Windows.