refactor(v2): clarify versions page #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit 84aa3c7 |
slorber
requested changes
Oct 12, 2020
There was a problem hiding this comment.
Hi,
LGTM, but as we deploy the bootstrap theme without any version, the pastVersions array is empty (versioning disabled so that netlify build is not too slow due to multiple builds)
We should rather fallback to "latestVersion", or consider in render that stableVersion may be undefined.
| @@ -20,8 +20,9 @@ function Version() { | |||
| const pastVersions = versions.filter( | |||
| (version) => version !== latestVersion && version.name !== 'current', | |||
| ); | |||
|
|
|||
| const stableVersion = pastVersions.shift(); | |||
There was a problem hiding this comment.
Suggested change
| const stableVersion = pastVersions.shift(); | |
| const stableVersion = pastVersions.shift() ?? latestVersion; |
There was a problem hiding this comment.
(just an idea, this wn't lead to a good deploy preview versions page for the bootstrap theme, but probably not a big deal anyway)
There was a problem hiding this comment.
This solution is ok? 84aa3c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #3572
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)