Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add option for blog meta title #3571

Merged
merged 2 commits into from
Oct 12, 2020
Merged

feat(v2): add option for blog meta title #3571

merged 2 commits into from
Oct 12, 2020

Conversation

DeadEnglish
Copy link
Contributor

@DeadEnglish DeadEnglish commented Oct 10, 2020

Motivation

Fixing the issue raised within #3542

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

  • run yarn start
  • navigate to 'blog' page
  • check the title has been updated with blog title rather than previous blog
  • stop project from running
  • change the blog title within the blog config
  • restart docusarus
  • navigate to 'blog' page
  • check blog title has changed

Related PRs

#3542

@facebook-github-bot
Copy link
Contributor

Hi @DeadEnglish!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 10, 2020

Deploy preview for docusaurus-2 ready!

Built with commit d66064a

https://deploy-preview-3571--docusaurus-2.netlify.app

@DeadEnglish
Copy link
Contributor Author

CLA has been signed but I don't seem to be able to re-run the check 😬

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 10, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@slorber
Copy link
Collaborator

slorber commented Oct 12, 2020

LGTM, will just change the default title to "Blog" instead of "Blog title" for retrocompat, as it would be applied to our own blog 🤪

https://deploy-preview-3571--docusaurus-2.netlify.app/classic/blog

@slorber slorber linked an issue Oct 12, 2020 that may be closed by this pull request
@slorber slorber changed the title feat(blog-meta-title): add support for additional meta title feat(v2): add option for blog meta title Oct 12, 2020
@slorber slorber merged commit d151077 into facebook:master Oct 12, 2020
@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] Blog home page support different meta title
5 participants