-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added onRouteUpdate in versioned_docs 👨💻 #3444
Conversation
Added to version-2.0.0-alpha.63
Hi @imabp! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@slorber I have signed the Facebook's CLA and after that only I created this pull request. But its showing I have not. 🥺🥺 |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit a41209d |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@slorber help in reviewing the pr |
website/versioned_docs/version-2.0.0-alpha.63/docusaurus-core.md
Outdated
Show resolved
Hide resolved
@saadpasta Thanks for letting me know that fix. 😊😊 I have updated the pull request. @slorber please review PR. Bit excited for this 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imabp thanks for your contribution, but please add new information to the master docs, not the versioned ones.
@lex111 I have removed the changes in version_docs and updated the changes on master docs. Please review. @lex111 @saadpasta @slorber |
@slorber @lex111 @saadpasta I have made changes based on end user perspective. Please review |
Hi
Will be back from holiday on Monday 28 and catch up with PRs/issues soon
😉
Le mer. 16 sept. 2020 à 12:41, Abir <[email protected]> a écrit :
… @lex111 <https://github.com/lex111> @saadpasta
<https://github.com/saadpasta> I have made changes based on end user
perspective. Please review
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PQIBPUA5QGDCZ5L3ODSGCP57ANCNFSM4RJFQ3HA>
.
|
Hi, I'm sorry @imabp but I think you did not understand the purpose of this feature, and this doc is not good documentation for it. Unfortunately, I come back from holiday and have a lot of issues to check, so can't dedicate time to help you do this contribution. I'm going to close this PR. @saadpasta looks like you understand the feature better, do you want to send a PR? (Note: I don't think it's worth documenting |
Issue Reference: #3399
onRouteUpdate documented and Added to version-2.0.0-alpha.63
Motivation
Excited for first time contribution to Facebook's repository.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
@slorber Please review
No code has been changed. But documented the life cycle events.
Related PRs
No