Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onRouteUpdate in versioned_docs 👨‍💻 #3444

Closed
wants to merge 5 commits into from
Closed

Added onRouteUpdate in versioned_docs 👨‍💻 #3444

wants to merge 5 commits into from

Conversation

imabp
Copy link

@imabp imabp commented Sep 12, 2020

Issue Reference: #3399
onRouteUpdate documented and Added to version-2.0.0-alpha.63

Motivation

Excited for first time contribution to Facebook's repository.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

@slorber Please review
No code has been changed. But documented the life cycle events.
image

Related PRs

No

Added to version-2.0.0-alpha.63
@imabp imabp requested a review from yangshun as a code owner September 12, 2020 07:34
@facebook-github-bot
Copy link
Contributor

Hi @imabp!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@imabp
Copy link
Author

imabp commented Sep 12, 2020

@slorber I have signed the Facebook's CLA and after that only I created this pull request. But its showing I have not. 🥺🥺
image

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 12, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit a41209d

https://deploy-preview-3444--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 12, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@imabp
Copy link
Author

imabp commented Sep 13, 2020

@slorber help in reviewing the pr

@imabp
Copy link
Author

imabp commented Sep 15, 2020

@saadpasta Thanks for letting me know that fix. 😊😊 I have updated the pull request.

@slorber please review PR. Bit excited for this 😁

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imabp thanks for your contribution, but please add new information to the master docs, not the versioned ones.

@imabp
Copy link
Author

imabp commented Sep 16, 2020

@lex111 I have removed the changes in version_docs and updated the changes on master docs.

Please review. @lex111 @saadpasta @slorber

@imabp imabp requested a review from lex111 September 16, 2020 08:02
website/docs/docusaurus-core.md Outdated Show resolved Hide resolved
@imabp
Copy link
Author

imabp commented Sep 16, 2020

@slorber @lex111 @saadpasta I have made changes based on end user perspective. Please review

@slorber
Copy link
Collaborator

slorber commented Sep 23, 2020 via email

@slorber
Copy link
Collaborator

slorber commented Sep 28, 2020

Hi,

I'm sorry @imabp but I think you did not understand the purpose of this feature, and this doc is not good documentation for it. Unfortunately, I come back from holiday and have a lot of issues to check, so can't dedicate time to help you do this contribution. I'm going to close this PR.

@saadpasta looks like you understand the feature better, do you want to send a PR?

(Note: I don't think it's worth documenting onRouteUpdateDelayed as it's used nowhere, if nobody complains I'd like to get it removed).

@slorber slorber closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants