Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): tab label showing outline & background when clicked #3171

Merged
merged 5 commits into from
Jul 31, 2020
Merged

fix(v2): tab label showing outline & background when clicked #3171

merged 5 commits into from
Jul 31, 2020

Conversation

mdfaizan7
Copy link
Contributor

Motivation

#3150

Have you read the Contributing Guidelines on pull requests?

Yes

Screenshots:

Before:

image

After:

image

@mdfaizan7 mdfaizan7 requested a review from lex111 as a code owner July 30, 2020 16:01
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 30, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 30, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit 159be91

https://deploy-preview-3171--docusaurus-2.netlify.app

@mdfaizan7 mdfaizan7 mentioned this pull request Jul 30, 2020
Closed
@Mihonarium
Copy link

Thanks for the PR, but to remove the outline and the background completely when there's a focus is not a solution. I wrote more in a comment in the issue.

@mdfaizan7 mdfaizan7 marked this pull request as draft July 30, 2020 17:27
@mdfaizan7 mdfaizan7 marked this pull request as ready for review July 30, 2020 19:46
@slorber slorber changed the title fix: tab label showing outline & background when clicked fix(v2): tab label showing outline & background when clicked Jul 31, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 31, 2020
@slorber
Copy link
Collaborator

slorber commented Jul 31, 2020

Thanks, that seems to do the job

@slorber slorber merged commit d560a52 into facebook:master Jul 31, 2020
@slorber slorber linked an issue Jul 31, 2020 that may be closed by this pull request
After being clicked with a mouse, tab labels show the outline and have a background #3150
Closed
@lex111 lex111 mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After being clicked with a mouse, tab labels show the outline and have a background
5 participants
@mdfaizan7 @docusaurus-bot @Mihonarium @slorber @facebook-github-bot