Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of tiny little fixes for issues I found while setting up docusaurus #312

Merged
merged 4 commits into from
Dec 18, 2017

Conversation

aadsm
Copy link
Contributor

@aadsm aadsm commented Dec 18, 2017

Motivation

Improve Docusaurus.

Test Plan

They are pretty tiny changes and I tested them using my local copy.
Broken link: I clicked on the link and checked that it loaded the intended website.
Support no users: I loaded the page with and without users and checked the intended behaviour.
Support no logo: I loaded the page with and without logo and checked the intended behaviour.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 18, 2017
@aadsm aadsm changed the title A bunch of tiny little changes of issues I found while setting up docusaurus A bunch of tiny little fixes for issues I found while setting up docusaurus Dec 18, 2017
@JoelMarcey
Copy link
Contributor

@aadsm Thank you very much for this pull request. Looks good.

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants