fix(v2): Use require.resolve to resolve plugin path in presets #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamChou19815
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit 62834d3 |
|
Deploy preview for docusaurus-2 ready! Built with commit c800cab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This diff continues the progress of making docusaurus v2 work under yarn v2's pnp mode.
require.resolvefor all webpack presets and plugins #2788, I ensured that all webpack presets and plugins can be correctly resolved by@docusaurus/core.@docusaurus/core.It would almost resolve almost all module resolution issues with yarn v2 pnp, except for presets. Docusaurus's presets still use plain string to refer to modules, which will make pnp module resolution fail.
In this diff, I fixed all the presets to use
require.resolvein this repo. I also updated the docs to educate preset writers to userequire.resolvein their code.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Everything can still be properly loaded, and the preview site still works.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)