Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): mention that appID is optional #2659

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Conversation

s-pace
Copy link

@s-pace s-pace commented Apr 25, 2020

Motivation

Update documentation related to DocSearch (I am part of the team behind it)

Have you read the Contributing Guidelines on pull requests?

Yes

@s-pace s-pace requested a review from yangshun as a code owner April 25, 2020 14:58
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 25, 2020
@lex111
Copy link
Contributor

lex111 commented Apr 25, 2020

@s-pace could you please duplicate this change for versioned docs as well?

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 25, 2020

Deploy preview for docusaurus-2 ready!

Built with commit cd2d23a

https://deploy-preview-2659--docusaurus-2.netlify.app

@lex111 lex111 merged commit 1471a6e into facebook:master Apr 25, 2020
@lex111
Copy link
Contributor

lex111 commented Apr 25, 2020

@s-pace thank you!

@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants