[DO-NOT-MERGE] Proof of concept TypeScript theme support with auto-generated human readable js #2614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This diff shows how I think TypeScript support for themes can be implemented. This is not production ready. This diff only shows how we can generate nice and human-readable js. It doesn't go further to implementing any swizzling logic proposed in #2470.
It uses a simple babel configuration that strip away the typescript types. The generated file's code style is not completely preserved, but it's still very readable. This is what you can get when you run
yarn strip-ts-types
in@docusaurus/theme-classic
:(Generated from
src/theme/NotFound.tsx
)(You can see from above example that the parentheses around jsx has been stripped away as well. If we really care about the style, we can run
prettier
on those generated js file after the babel step.)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run
yarn workspace @docusaurus/theme-classic strip-ts-types
to see what's generatedRelated PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)