refactor(v2): import lqip-loader to monorepo, fix build on Node 13, fix lint-staged #2544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During discussion with @yangshun about my problems with Node 13 I was able to find that outdated
sharp
package in one of core dependencies is the root of my issues.Fortunately it was
@endiliey/lqip-loader
package which is the fork of originallqip-loader
especially created for the Docusaurus anyway. @yangshun asked me if I want to handle the import of this package into Docusaurus monorepo and this PR is the result of that.It is just a init import, no tests (Endiliey package used old version of
mocha
), no TS, with the consent of @yangshun.This PR also fixes:
sharp
bump indocusaurus-plugin-ideal-image
and switch to peer dependencies in@docusaurus/lqip-loader
) - Enhancement: add support for Node.js 13 lovell/sharp#1909lint-staged
when adding new files to repo, this was changed in v10 - "⚠ Some of your tasks usegit add
command." lint-staged/lint-staged#775Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
base64
image code after refactor.Related PRs
lint-staged
bump