Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): import lqip-loader to monorepo, fix build on Node 13, fix lint-staged #2544

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Apr 5, 2020

Motivation

During discussion with @yangshun about my problems with Node 13 I was able to find that outdated sharp package in one of core dependencies is the root of my issues.

Fortunately it was @endiliey/lqip-loader package which is the fork of original lqip-loader especially created for the Docusaurus anyway. @yangshun asked me if I want to handle the import of this package into Docusaurus monorepo and this PR is the result of that.

It is just a init import, no tests (Endiliey package used old version of mocha), no TS, with the consent of @yangshun.

This PR also fixes:

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  • I have checked the install, build and run of V2 website locally.
  • I have also verified the generated base64 image code after refactor.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 5, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 3f309af

https://deploy-preview-2544--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's make follow up PRs to do:

  • Convert tests to Jest
  • Potentially convert the loader to TypeScript

@yangshun yangshun merged commit 980f104 into facebook:master Apr 5, 2020
@yangshun yangshun added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants