Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add showReadingTime and editUrl to the templates #2541

Merged
merged 14 commits into from
Apr 5, 2020

Conversation

fanny
Copy link
Contributor

@fanny fanny commented Apr 5, 2020

Motivation

Since, we included new fields for our blog plugin, it would be nice define them to the templates.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

  1. yarn install in the docusaurus-init,
  2. Go to any template's directory, like: cd classic && yarn start.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)
#2524; #2531

@fanny fanny requested review from lex111, wgao19 and yangshun as code owners April 5, 2020 14:42
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 5, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 5, 2020

Deploy preview for docusaurus-2 ready!

Built with commit fbdcabe

https://deploy-preview-2541--docusaurus-2.netlify.com

@yangshun yangshun added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: new feature This PR adds a new API or behavior. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Apr 5, 2020
@yangshun yangshun changed the title feat(v2): Add showReadingTime and editUrl to the templates feat(v2): add showReadingTime and editUrl to the templates Apr 5, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Fanny!

@yangshun yangshun merged commit c09835a into facebook:master Apr 5, 2020
mohrash92 pushed a commit to mohrash92/docusaurus that referenced this pull request Apr 11, 2020
…2541)

* Add mdx plugins

* Apply suggestions from code review

Co-Authored-By: Alexey Pyltsyn <[email protected]>

* Update website/docs/markdown-features.mdx

Co-Authored-By: Alexey Pyltsyn <[email protected]>

* Update markdown-features.mdx

* Update templates with new fields

* Rebase

* fix(v2): tests

* Update docusaurus.config.js

* Update docusaurus.config.js

* Update docusaurus.config.js

* Update docusaurus.config.js

Co-authored-by: Yangshun Tay <[email protected]>
Co-authored-by: Alexey Pyltsyn <[email protected]>
@fanny fanny deleted the feat/add-new-fields-in-template branch April 11, 2020 22:03
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants