-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add showReadingTime and editUrl to the templates #2541
Merged
yangshun
merged 14 commits into
facebook:master
from
fanny:feat/add-new-fields-in-template
Apr 5, 2020
Merged
feat(v2): add showReadingTime and editUrl to the templates #2541
yangshun
merged 14 commits into
facebook:master
from
fanny:feat/add-new-fields-in-template
Apr 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Alexey Pyltsyn <[email protected]>
Co-Authored-By: Alexey Pyltsyn <[email protected]>
Deploy preview for docusaurus-2 ready! Built with commit fbdcabe |
yangshun
added
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
pr: new feature
This PR adds a new API or behavior.
and removed
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
labels
Apr 5, 2020
yangshun
changed the title
feat(v2): Add showReadingTime and editUrl to the templates
feat(v2): add showReadingTime and editUrl to the templates
Apr 5, 2020
yangshun
approved these changes
Apr 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Fanny!
mohrash92
pushed a commit
to mohrash92/docusaurus
that referenced
this pull request
Apr 11, 2020
…2541) * Add mdx plugins * Apply suggestions from code review Co-Authored-By: Alexey Pyltsyn <[email protected]> * Update website/docs/markdown-features.mdx Co-Authored-By: Alexey Pyltsyn <[email protected]> * Update markdown-features.mdx * Update templates with new fields * Rebase * fix(v2): tests * Update docusaurus.config.js * Update docusaurus.config.js * Update docusaurus.config.js * Update docusaurus.config.js Co-authored-by: Yangshun Tay <[email protected]> Co-authored-by: Alexey Pyltsyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since, we included new fields for our blog plugin, it would be nice define them to the templates.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
yarn install
in the docusaurus-init,cd classic && yarn start
.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)
#2524; #2531