Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): update HTML markup of pagination for better a11y #2495

Merged
merged 1 commit into from
Apr 2, 2020
+12 −12
Merged

refactor(v2): update HTML markup of pagination for better a11y #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/docusaurus-theme-classic/src/theme/BlogPostPaginator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ function BlogPostPaginator(props) {
<div className="pagination-nav__item">
{prevItem && (
<Link className="pagination-nav__link" to={prevItem.permalink}>
<h5 className="pagination-nav__link--sublabel">Previous Post</h5>
<h4 className="pagination-nav__link--label">
<div className="pagination-nav__link--sublabel">Previous Post</div>
<div className="pagination-nav__link--label">
&laquo; {prevItem.title}
</h4>
</div>
</Link>
)}
</div>
<div className="pagination-nav__item pagination-nav__item--next">
{nextItem && (
<Link className="pagination-nav__link" to={nextItem.permalink}>
<h5 className="pagination-nav__link--sublabel">Next Post</h5>
<h4 className="pagination-nav__link--label">
<div className="pagination-nav__link--sublabel">Next Post</div>
<div className="pagination-nav__link--label">
{nextItem.title} &raquo;
</h4>
</div>
</Link>
)}
</div>
Expand Down
12 changes: 6 additions & 6 deletions packages/docusaurus-theme-classic/src/theme/DocPaginator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ function DocPaginator(props) {
<Link
className="pagination-nav__link"
to={metadata.previous.permalink}>
<h5 className="pagination-nav__link--sublabel">Previous</h5>
<h4 className="pagination-nav__link--label">
<div className="pagination-nav__link--sublabel">Previous</div>
<div className="pagination-nav__link--label">
&laquo; {metadata.previous.title}
</h4>
</div>
</Link>
)}
</div>
<div className="pagination-nav__item pagination-nav__item--next">
{metadata.next && (
<Link className="pagination-nav__link" to={metadata.next.permalink}>
<h5 className="pagination-nav__link--sublabel">Next</h5>
<h4 className="pagination-nav__link--label">
<div className="pagination-nav__link--sublabel">Next</div>
<div className="pagination-nav__link--label">
{metadata.next.title} &raquo;
</h4>
</div>
</Link>
)}
</div>
Expand Down