polish(v2): use npm-to-yarn for the npm2yarn remark plugin #2428
Conversation
|
Hi @nebrelbug! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Deploy preview for docusaurus-2 ready! Built with commit 7a44aae |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Strangely, the bottom two This is with the most recent changes, and testing both |
|
After fixing a few bugs in my NPM package, I can confirm that I didn't see any failed conversions while browsing the docs (except the codeblock that says |
yangshun
changed the title
yangshun
added
the
pr: polish
Motivation
Docusaurus' previous NPM-Yarn code tab generation was very basic and missed many conversions. I extracted some of the logic into a new npm package (
npm-to-yarn) and made the code more robust.Have you read the Contributing Guidelines on pull requests?
Yep
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
When serving on localhost, NPM to Yarn code tab generation works in almost all cases (though for some reason, it seems to fail, as did the last implementation, on one-line codeblocks? I think it's a problem with the Remark plugin)Actually, the problems I observed previously aren't there any more. Conversions seem to be working perfectly
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)
None yet