fix(v1): check repoUrl before using on users.js #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 7d0374e |
lex111
suggested changes
Feb 26, 2020
lex111
reviewed
Feb 26, 2020
lex111
changed the title
lex111
reviewed
Feb 26, 2020
jsjoeio
force-pushed
the
jsjoeio/fix-2275
branch
from
7aa4040 to
4dd4f09
Compare
|
Separate PR opened for the doc change: #2333 |
lex111
approved these changes
Feb 26, 2020
|
@jsjoeio thank you! 😃 |
|
@lex111 Thank YOU for the code suggestions! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
siteConfigto remove extra whitespace in code commentHave you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
I first reproduced the issue locally following the instructions in the issue. After that, I implemented the change they suggested in that local docusaurus project and it fixed the issue.
Related PRs
N/A