Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): include base url in 404 route #2237

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 21, 2020

Motivation

This PR resolves #2229.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See To Reproduce section in issue #2229.

@lex111 lex111 requested a review from yangshun as a code owner January 21, 2020 21:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 21, 2020
@lex111 lex111 added pr: bug fix This PR fixes a bug in a past release. and removed CLA Signed Signed Facebook CLA labels Jan 21, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 21, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 64c8329

https://deploy-preview-2237--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alexey!

@yangshun yangshun merged commit 06044cf into facebook:master Jan 22, 2020
@yangshun yangshun deleted the 404-base-url branch January 22, 2020 01:00
@lex111 lex111 restored the 404-base-url branch April 18, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] 404.html routePath does not include siteConfig.baseUrl
4 participants