refactor(v2): move scripts/stylesheets injection to server side #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to server side using injectHtmlTag API
endiliey
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit 8b9e473 |
|
Deploy preview for docusaurus-preview ready! Built with commit 8b9e473 |
|
sounded a bit peculiar to me at first but actually quite legit on a second thought, smart idea （╹◡╹） |
|
because its a global tag and not page specific. |
yangshun
approved these changes
Dec 4, 2019
| injectHtmlTags: () => { | ||
| const stylesheetsTags = stylesheets.map(source => | ||
| typeof source === 'string' | ||
| ? `<link rel="stylesheet" href="${source}">` |
There was a problem hiding this comment.
This API comes in handy now 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move scripts/stylesheets siteConfig client side injection to server side using injectHtmlTag API
The benefit of this approach is that there won't be weird
data-helmetattribute on the injected head tags and theoretically server side should be faster than react helmet.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Nothing broke
Add random scripts and stylesheets into config
To consider
Deprecate scripts and stylesheets option ? But that would require v1 user migrating having to create a local plugin which can be slightly annoying