fix(v2): use regular div instead of main tag for wrapper layout page

[lex111]

Motivation

Now I just noticed that the main tag is already used in the template, so it makes sense to replace it with a regular div.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See HTML markup, no changes UI.

[docusaurus-bot]

Deploy preview for docusaurus-2 ready!

Built with commit 0fa575e

https://deploy-preview-1978--docusaurus-2.netlify.com

[docusaurus-bot]

Deploy preview for docusaurus-preview ready!

Built with commit 0fa575e

https://deploy-preview-1978--docusaurus-preview.netlify.com

[yangshun]

Maybe we should change doc to not use <main> instead?

[endiliey]

Maybe we should change doc to not use

instead?

The <main> tag specifies the main content of a document.
The content inside the <main> element should be unique to the document. It should not contain any content that is repeated across documents such as sidebars, navigation links, copyright information, site logos, and search forms according to

By putting main on wrapper layout, we're not letting user to fine-grain control what's the main content for pages. iirc I put <main> in doc because algolia and search bot crawls our content better, not crawling unnecessary stuff

docusaurus/packages/docusaurus-theme-classic/src/theme/DocPage/index.js

Lines 37 to 55 in 2493583

	<Layout>
	<div className={styles.docPage}>
	{sidebar && (
	<div className={styles.docSidebarContainer}>
	<DocSidebar
	docsSidebars={docsSidebars}
	location={location}
	sidebar={sidebar}
	sidebarCollapsible={sidebarCollapsible}
	/>
	</div>
	)}
	<main className={styles.docMainContainer}>
	<MDXProvider components={MDXComponents}>
	{renderRoutes(route.routes)}
	</MDXProvider>
	</main>
	</div>
	</Layout>

This is correct fix, we must not have two <main>

[lex111]

No, main is used also on pages, it seems to me that I need to let the user determine where to use this tag. Especially main now covers sidebar, rather just text content.

[endiliey]

@lex111 we had the same thought 😆

[yangshun]

Cool, thanks for explaining!