Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify sidebar description #10810

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

ivancheban
Copy link
Contributor

@ivancheban ivancheban commented Jan 3, 2025

Removed at its crux because this phrase confuses the users who are not native speakers. The phrase "at its crux" means "at its core" or "at its essence." It doesn't provide the useful information for this sentence, so can be removed.

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

Removed at its crux because this phrase confuses the users who are not native speakers. The phrase "at its crux" means "at its core" or "at its essence." It doesn't provide the useful information for this sentence, so can be removed.
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ce09cf1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6777afef0ed74000084f6b55
😎 Deploy Preview https://deploy-preview-10810--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 3, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 46 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🔴 48 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 72 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 46 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber slorber changed the title Update index.mdx docs: simplify sidebar description Jan 3, 2025
@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jan 3, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, agree we should use simpler terms 👍

@slorber slorber merged commit 1b44d7a into facebook:main Jan 3, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants