-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(showcase): remove sites not using Docusaurus anymore #10393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thanks for the maintenance help 👍 Let me know if there are others you want to remove before merge |
slorber
added
the
pr: documentation
This PR works on the website or other text documents in the repo.
label
Aug 12, 2024
slorber
changed the title
docs: Users.tsx cleanup
docs(showcase): remove sites not using Docusaurus anymore
Aug 12, 2024
I know that Hermes is no longer using Docusaurus (AFAIK), since their website just redirects to their GH. |
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
Closed
This was referenced Oct 4, 2024
This was referenced Oct 19, 2024
Open
Open
This was referenced Oct 20, 2024
Merged
This was referenced Nov 10, 2024
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: documentation
This PR works on the website or other text documents in the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR addresses the issue of non-compliant entries in the
users.tsx
file by removing links that are not using Docusaurus.Twelve non-compliant entries were identified and removed.
I am aware of the ongoing PR adding a showcase plugin to check links, but as of now, there are incorrect links in the showcase, including some that direct to sites with potential malware.
I can address additional links problems in this PR if it's okay for you.
Test Plan
The changes were tested by verifying that each removed link no longer appears in the
users.tsx
file.Additionally, I've ensured that the remaining links are correctly listed.
Related issues/PRs
#9967
Not Using Docusaurus
Malware Link - DO NOT CLICK