Merge branch 'main' into jc/fix-theme-init

.eslintrc.js

@@ -49,14 +49,7 @@ module.exports = {
     'import/no-unresolved': [
       ERROR,
       {
-        ignore: [
-          '^@theme',
-          '^@docusaurus',
-          '^@generated',
-          '^@site',
-          'unist',
-          'mdast',
-        ],
+        ignore: ['^@theme', '^@docusaurus', '^@generated', '^@site'],
       },
     ],
     'import/extensions': OFF,
@@ -149,6 +142,7 @@ module.exports = {
         allowSingleExtends: true,
       },
     ],
+    '@typescript-eslint/method-signature-style': ERROR,
     'no-restricted-imports': [
       ERROR,
       {
@@ -167,7 +161,6 @@ module.exports = {
               'head',
               'tail',
               'initial',
-              'last',
             ],
             message: 'These APIs have their ES counterparts.',
           },

.github/workflows/lint.yml

@@ -23,6 +23,6 @@ jobs:
       - name: Lint
         run: yarn lint:ci
       - name: Prettier Code
-        run: yarn prettier:diff
+        run: yarn format:diff
       - name: Prettier Docs
-        run: yarn prettier-docs:diff
+        run: yarn format-docs:diff

.github/workflows/showcase-test.yml

@@ -0,0 +1,26 @@
+name: Showcase Tests
+
+on:
+  pull_request:
+    branches:
+      - main
+    paths:
+      - website/src/data/**
+
+jobs:
+  validate-config:
+    name: Validate Showcase Config
+    timeout-minutes: 30
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ matrix.node }}
+          cache: yarn
+      - name: Installation
+        run: yarn
+      - name: Test
+        run: yarn test website/src/data/__tests__/user.test.ts
+  # TODO another job to optimize the images, see https://github.com/facebook/docusaurus/issues/5980

.github/workflows/tests-e2e.yml

@@ -30,19 +30,22 @@ jobs:
       - name: Installation
         run: yarn
       - name: Generate test-website project against main branch
-        run: |
-          KEEP_CONTAINER=true yarn test:build:website -s
-          mv test-website ../test-website
+        run: yarn test:build:website -s
+        env:
+          KEEP_CONTAINER: true
       - name: Install test-website project with Yarn v1
-        run: cd ../test-website && yarn install
+        run: yarn install
+        working-directory: ../test-website
         env:
           npm_config_registry: http://localhost:4873
       - name: Start test-website project
-        run: cd ../test-website && yarn start --no-open
+        run: yarn start --no-open
+        working-directory: ../test-website
         env:
           E2E_TEST: true
       - name: Build test-website project
-        run: cd ../test-website && yarn build
+        run: yarn build
+        working-directory: ../test-website
         env:
           CI: true
 
@@ -63,15 +66,12 @@ jobs:
           cache: yarn
       - name: Installation
         run: yarn
-
       - name: Generate test-website project against main branch
-        run: |
-          KEEP_CONTAINER=true yarn test:build:website -s
-          mv test-website ../test-website
+        run: yarn test:build:website -s
+        env:
+          KEEP_CONTAINER: true
       - name: Install test-website project with Yarn Berry and nodeLinker = ${{ matrix.nodeLinker }}
         run: |
-          cd ../test-website
-
           # we have to switch to berry first before setting the version we want
           yarn set version berry
           # temporary using canary for #5342
@@ -84,13 +84,16 @@ jobs:
           yarn config set enableGlobalCache true
 
           yarn install
+        working-directory: ../test-website
         env:
           YARN_ENABLE_IMMUTABLE_INSTALLS: false # Yarn berry should create the lockfile, despite CI env
       - name: Start test-website project
-        run: cd ../test-website && yarn start --no-open
+        run: yarn start --no-open
+        working-directory: ../test-website
         env:
           E2E_TEST: true
       - name: Build test-website project
-        run: cd ../test-website && yarn build
+        run: yarn build
+        working-directory: ../test-website
         env:
           CI: true