Skip to content

Commit

Permalink
fix: declare missing dependencies (#6097)
Browse files Browse the repository at this point in the history
* fix(utils-validation): add missing peer dependencies `react` and `react-dom`

* fix(theme-classic): add missing peer dependency `@docusaurus/core`

* ci: disable PnP fallbacks

* ci: link to the docs

* Update package.json

Co-authored-by: Joshua Chen <[email protected]>
  • Loading branch information
merceyz and Josh-Cena authored Dec 13, 2021
1 parent 5fb6404 commit b48c6de
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .github/workflows/tests-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ jobs:
yarn config set unsafeHttpWhitelist --json '["localhost"]'
yarn config set enableGlobalCache true
# Make PnP as strict as possible
# https://yarnpkg.com/features/pnp#fallback-mode
yarn config set pnpFallbackMode none
# Patch package so that peer deps are provided. This has been fixed in terser by making acorn a direct dependency
# TODO watch out for the next terser release. Commit: https://github.com/terser/terser/commit/05b23eeb682d732484ad51b19bf528258fd5dc2a
yarn config set packageExtensions --json '{"terser-webpack-plugin@*": {"dependencies": {"acorn": "^8.6.0"}}, "html-minifier-terser@*": {"dependencies": {"acorn": "^8.6.0"}}}'
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"update-code-translations": "node -e 'require(\"./update-code-translations.js\").run()'"
},
"dependencies": {
"@docusaurus/core": "2.0.0-beta.13",
"@docusaurus/plugin-content-blog": "2.0.0-beta.13",
"@docusaurus/plugin-content-docs": "2.0.0-beta.13",
"@docusaurus/plugin-content-pages": "2.0.0-beta.13",
Expand All @@ -45,7 +46,6 @@
"rtlcss": "^3.3.0"
},
"devDependencies": {
"@docusaurus/core": "2.0.0-beta.13",
"@docusaurus/module-type-aliases": "2.0.0-beta.13",
"@docusaurus/types": "2.0.0-beta.13",
"@types/mdx-js__react": "^1.5.4",
Expand Down
4 changes: 4 additions & 0 deletions packages/docusaurus-utils-validation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
"joi": "^17.4.2",
"tslib": "^2.3.1"
},
"peerDependencies": {
"react": "*",
"react-dom": "*"
},
"engines": {
"node": ">=14"
}
Expand Down

0 comments on commit b48c6de

Please sign in to comment.