fix(utils): fix Markdown link replacement when link text is same as h…

…ref (#7464)
facebook · May 22, 2022 · 6e62bba · 6e62bba
1 parent 5207e25
commit 6e62bba
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/packages/docusaurus-utils/src/__tests__/__snapshots__/markdownLinks.test.ts.snap b/packages/docusaurus-utils/src/__tests__/__snapshots__/markdownLinks.test.ts.snap
@@ -102,10 +102,10 @@ exports[`replaceMarkdownLinks replaces links with same title as URL 1`] = `
 {
   "brokenMarkdownLinks": [],
   "newContent": "
-[/docs/foo](foo.md)
-[/docs/foo](./foo.md)
 [foo.md](/docs/foo)
-[.//docs/foo](foo.md)
+[./foo.md](/docs/foo)
+[foo.md](/docs/foo)
+[./foo.md](/docs/foo)
 ",
 }
 `;

diff --git a/packages/docusaurus-utils/src/__tests__/markdownLinks.test.ts b/packages/docusaurus-utils/src/__tests__/markdownLinks.test.ts
@@ -204,7 +204,6 @@ The following operations are defined for [URI]s:
     ).toMatchSnapshot();
   });
 
-  // FIXME
   it('replaces links with same title as URL', () => {
     expect(
       replaceMarkdownLinks({

diff --git a/packages/docusaurus-utils/src/markdownLinks.ts b/packages/docusaurus-utils/src/markdownLinks.ts
@@ -137,7 +137,10 @@ export function replaceMarkdownLinks<T extends ContentPaths>({
           .split('/')
           .map((part) => part.replace(/\s/g, '%20'))
           .join('/');
-        modifiedLine = modifiedLine.replace(mdLink, encodedPermalink);
+        modifiedLine = modifiedLine.replace(
+          mdMatch[0]!,
+          mdMatch[0]!.replace(mdLink, encodedPermalink),
+        );
         // Adjust the lastIndex to avoid passing over the next link if the
         // newly replaced URL is shorter.
         mdRegex.lastIndex += encodedPermalink.length - mdLink.length;