fix(v2): fix link items refusing attributes like target, rel etc... (#…

…3168)
facebook · Jul 30, 2020 · 68f4bd0 · 68f4bd0
1 parent 4af25cd
commit 68f4bd0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/packages/docusaurus-init/templates/facebook/docusaurus.config.js b/packages/docusaurus-init/templates/facebook/docusaurus.config.js
@@ -92,14 +92,10 @@ module.exports = {
             {
               label: 'Privacy',
               href: 'https://opensource.facebook.com/legal/privacy/',
-              target: '_blank',
-              rel: 'noreferrer noopener',
             },
             {
               label: 'Terms',
               href: 'https://opensource.facebook.com/legal/terms/',
-              target: '_blank',
-              rel: 'noreferrer noopener',
             },
           ],
         },

diff --git a/packages/docusaurus-theme-classic/src/themeConfigSchema.js b/packages/docusaurus-theme-classic/src/themeConfigSchema.js
@@ -111,6 +111,20 @@ const ColorModeSchema = Joi.object({
   respectPrefersColorScheme: false,
 });
 
+const FooterLinkItemSchema = Joi.object({
+  to: Joi.string(),
+  href: Joi.string().uri(),
+  html: Joi.string(),
+  label: Joi.string(),
+})
+  .xor('to', 'href', 'html')
+  .with('to', 'label')
+  .with('href', 'label')
+  .nand('html', 'label')
+  // We allow any unknown attributes on the links
+  // (users may need additional attributes like target, aria-role, data-customAttribute...)
+  .unknown();
+
 const ThemeConfigSchema = Joi.object({
   // TODO temporary (@alpha-58)
   disableDarkMode: Joi.any().forbidden(false).messages({
@@ -158,18 +172,7 @@ const ThemeConfigSchema = Joi.object({
     links: Joi.array().items(
       Joi.object({
         title: Joi.string().required(),
-        items: Joi.array().items(
-          Joi.object({
-            to: Joi.string(),
-            href: Joi.string().uri(),
-            html: Joi.string(),
-            label: Joi.string(),
-          })
-            .xor('to', 'href', 'html')
-            .with('to', 'label')
-            .with('href', 'label')
-            .nand('html', 'label'),
-        ),
+        items: Joi.array().items(FooterLinkItemSchema).default([]),
       }),
     ),
   }),