Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: page doesn't get refreshed when FAST_REFRESH=false #9884

Merged
merged 2 commits into from
Oct 26, 2020
Merged

fix: page doesn't get refreshed when FAST_REFRESH=false #9884

merged 2 commits into from
Oct 26, 2020

Conversation

n3tr
Copy link
Contributor

@n3tr n3tr commented Oct 24, 2020

Page doesn't get refreshed when disabling FAST_REFRESH. This is because the process.env.FAST_REFRESH in webpackHotDevClient is a boolean value, comparing !== 'false' will always return true.

Verify steps

  • yarn create-react-app my-app
  • yarn start
  • Modify App.js content
  • The app gets updated through Fast Refresh

FAST_REFRESH=false

  • Start the app by using FAST_REFRESH=false yarn start
  • Modify App.js
  • The app should do a full reload

@ianschmitz ianschmitz added this to the 4.0.1 milestone Oct 26, 2020
@ianschmitz ianschmitz changed the title [v4] Fix page doesn't get refreshed when FAST_REFRESH=false fix: page doesn't get refreshed when FAST_REFRESH=false Oct 26, 2020
@ianschmitz ianschmitz merged commit 7e48117 into facebook:master Oct 26, 2020
@ianschmitz
Copy link
Contributor

Great find. Thanks!

@obsius obsius mentioned this pull request Oct 28, 2020
Open
@obsius obsius mentioned this pull request Nov 17, 2020
Open
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@n3tr @ianschmitz @wombleton
fix: page doesn't get refreshed when FAST_REFRESH=false (facebook#9884)
ecfdb76 
Co-authored-by: Ian Schmitz <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Oct 5, 2022
Open
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
@n3tr @ianschmitz @abhiisheek
fix: page doesn't get refreshed when FAST_REFRESH=false (facebook#9884)
ddb5b0b 
Co-authored-by: Ian Schmitz <[email protected]>
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@n3tr @ianschmitz @abhiisheek
fix: page doesn't get refreshed when FAST_REFRESH=false (facebook#9884)
4d9ba3d 
Co-authored-by: Ian Schmitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@n3tr @ianschmitz @facebook-github-bot