Add support for `PUBLIC_URL` env variable #937

EnoahNetzach · 2016-10-20T15:39:55Z

Solves #936, introducing the possibility to specify the PUBLIC_URL env variable while running npm run build.

With this PR the %PUBLIC_URL% in static assets and the output.publicPath variable set in webpack configs follow the following behavior:

"homepage" specified in package.json, PUBLIC_URL not set: only the pathname is used from "homepage" (as it is right now);
PUBLIC_URL set, "homepage" might be set: the full url specified in the env variable is used

dapids · 2016-10-21T07:24:42Z

packages/react-scripts/package.json

@@ -4,6 +4,7 @@
  "description": "Configuration and scripts for Create React App.",
  "repository": "facebookincubator/create-react-app",
  "license": "BSD-3-Clause",
+  "homepage": "https://s3.eu-central-1.amazonaws.com/my-project",


I think this just slipped in by mistake.

lexfrl · 2016-10-21T18:28:38Z

is that related? #931

mars · 2016-10-22T02:49:38Z

(Repeated from issue comment)

How about namespacing this as REACT_APP_PUBLIC_URL so that it's automatically white listed into process.env along with other custom environment vars?

gaearon

Thank you! This looks reasonable. I left a few comments for how I would prefer to see these changes.

gaearon · 2016-10-28T12:39:47Z

packages/react-scripts/config/webpack.config.prod.js

 var homepagePathname = homepagePath ? url.parse(homepagePath).pathname : '/';
+var servedPath = process.env.PUBLIC_URL ? homepagePath : homepagePathname;


Can we avoid duplication in reading process.env? I feel like this may cause subtle bugs. Ideally the source of truth should be in config/paths and we should derive everything based on it. It's fine if it also calculates servedPath.

gaearon · 2016-10-28T12:40:16Z

packages/react-scripts/config/paths.js

@@ -85,3 +85,7 @@ if (__dirname.indexOf(path.join('packages', 'react-scripts', 'config')) !== -1)
    nodePaths: nodePaths
  };
 }
+
+configs.publicUrl = process.env.PUBLIC_URL ? process.env.PUBLIC_URL : require(configs.appPackageJson).homepage;


I'd prefer we write getPublicUrl() and call it from every individual config block.

should I leave the var config or revert to multiple module.exports?

I'd keep it as multiple module.exports.

andreypopp · 2016-11-02T17:55:40Z

packages/react-scripts/scripts/build.js

-      console.log('The project was built assuming it is hosted at ' + chalk.green(publicPath) + '.');
-      console.log('You can control this with the ' + chalk.green('homepage') + ' field in your '  + chalk.cyan('package.json') + '.');
+      console.log('The project was built assuming it is hosted at ' + chalk.green(publicPathname) + '.');
+      console.log('You can control this with the ' + chalk.green('homepage') + ' field in your '  + chalk.cyan('package.json') + ', or with the ' + chalk.green('PUBLIC_URL') + ' environment variable.');


I'm not even sure we should keep ""homepage" key in package.json"-approach working. It is confusing that package.json contains deploy specific info, don't you think?

Were it for me, I'd drop it entirely.
I think also that the double behavior ("homepage" -> pathname vs PUBLIC_URL -> URL) could be misleading.
If you want the pathname only, give the pathname only.

The only downside I see is if someone were to publish to gh-pages, and inserted the pathname only. The good explanation about how to publish it is lost..

I realize this is an older post but this might help for publishing to gh-pages with a set homepage: https://itnext.io/so-you-want-to-host-your-single-age-react-app-on-github-pages-a826ab01e48

gaearon · 2016-11-03T14:23:44Z

I'm not even sure we should keep ""homepage" key in package.json"-approach working.

What do you suggest? I wouldn't want to tell beginners to use environment variables. A lot of people don't know what those are.

gaearon · 2016-11-03T14:24:20Z

Also referring to public URL in code sounds like a fairly advanced use case for me.

EnoahNetzach · 2016-11-03T14:27:59Z

A lot of people don't know what those are.

We could replicate the same behavior both in "homepage" and in PUBLIC_URL, so no distinction between pathname and URL.

Also referring to public URL in code sounds like a fairly advanced use case for me.

You mean using process.env.PUBLIC_URL in a js file?

EnoahNetzach · 2016-11-03T14:32:30Z

A possible solution for the "gh-pages" issue I was talking about earlier is:

a full URL is provided -> if it has a .github.io domain, the explanation is shown
a pathname is provided -> the explanation is shown always

Instead of a direct explanation, a url to a doc page explaining how to deploy it could be used.

gaearon · 2016-11-03T14:34:11Z

We could replicate the same behavior both in "homepage" and in PUBLIC_URL, so no distinction between pathname and URL.

Not sure I understand what you mean, could you clarify? If you propose a change maybe it's better to file a separate issue so the discussion doesn't get lost.

You mean using process.env.PUBLIC_URL in a js file?

Yes.

EnoahNetzach · 2016-11-03T14:44:44Z

could you clarify?

With this PR I split the behavior in two (@see):

if only the "homepage" field is filled, then only its pathname is used
if the PUBLIC_URL env var is set, then the full URL is used

This is misleading to me (even to explain it is not so simple..), so I'm proposing to use only the second behavior for both "homepage" and PUBLIC_URL. (e.g. in the aforementioned line homepagePath is always returned).

If you propose a change maybe it's better to file a separate issue so the discussion doesn't get lost.

This is about the very substance of this PR 😛.

andreypopp · 2016-11-03T14:53:57Z

What do you suggest? I wouldn't want to tell beginners to use environment variables. A lot of people don't know what those are.

They are still used widely (by the way ReactJS docs mention NODE_ENV env var). I think with proper instructions provided beginners won't be confused and will just treat/understand it as some sort of a command line flag.

gaearon · 2016-11-03T15:01:07Z

They are still used widely (by the way ReactJS docs mention NODE_ENV env var)

Yet you don't specify it with a command line if you use Webpack. In a way it's fake.

This is about the very substance of this PR 😛.

Isn't this PR introducing a new feature rather than changing how existing feature works? If I understand correctly, this PR makes it so:

By default everything works just like before. Public URL is inferred from homepage.
You can now override public URL with an environment variable. If you do so, it is up to you whether to make it a full URL or just a pathname, depending on whether you care about using a CDN (use full URL) or about being able to deploy on multiple hosts (use pathname).

If you think it's too confusing and you’d rather change the behavior completely (e.g. eliminate homepage inference) let’s discuss in a separate issue. But a change like this would be harder for me to justify since it forces people to learn using environment variables for most trivial task (publishing on GitHub).

gaearon · 2016-11-03T15:07:40Z

For the record, the reason I want to keep this option "hidden" and keep homepage is because people don't understand what "public path" is. Is it /? Is it filesystem path where my project is? Is it /public? Is it /build? Just check all the broken configs in Webpack issues.

When people realize they need to fill out homepage this is not a problem anymore. You can't misunderstand how to write URL to your own project. So, while a bit unconventional, it works well in my opinion.

I intend the option introduced in this PR to be advanced, just like all other options we allow via environment variables. Most people won't even know that it exists. Those who need it will find instructions and we can document what exactly it does. I don't think it's too confusing.

We need to make 80% simple, and 20% possible. Not 100% simple because this really means "100% relatively complex" for most people. Like Webpack.

EnoahNetzach · 2016-11-03T15:09:06Z

let’s discuss in a separate issue.

I see why, now!

So let it be as is, I'll open another PR in order to simplify the behavior once and if this one gets merged ;)

Thank you @gaearon!

jjasonclark · 2016-11-05T18:21:32Z

Is it possible this fix could also be applied to development mode?

Let me explain an example use.

One use case of hosting your Create-React-App (CRA) under a URL prefix (homepage setting) is having a proxy server in front performing routing based on URLs. In addition to developing and testing the CRA app in isolation, one will frequently also test and develop with the whole system in place. Meaning the web request would go through the front proxy onto the CRA development server. This works great for the index page. But the routes inside the index page are all based on root (/) and not the homepage setting. Without using the homepage setting this setup breaks down.

EnoahNetzach · 2016-11-06T10:08:43Z

@jjasonclark don't know if this could be useful information, but when we have to test the integration with our main site in dev mode we use an initialization phase where we pass to our build the base path, which is automatically prepended to all our react routes.

gaearon · 2016-11-20T18:23:34Z

Sorry for the trouble but could you please rebase?

EnoahNetzach · 2016-11-21T11:00:57Z

@gaearon no trouble at all ;)

EnoahNetzach · 2016-11-25T00:50:01Z

had to rebase from upstream yet again because the last rebase broke the build script (index.html had a base64 in it...)

fson · 2016-11-26T13:31:09Z

@gaearon can you finish the code review? Is this accepted?

* Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

* Add `PUBLIC_URL` env variable for advanced use (#937) * Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

Timer · 2017-02-10T04:16:44Z

Merged as part of #1504. Thanks!

edit: github squashed and inherited the wrong author on #1504 -- sorry about the lack of git blame. Let me know how I can make it up to you.

EnoahNetzach · 2017-02-10T09:01:47Z

@Timer no worries, just a question: why did you have to open another PR and not comment/edit/accept this one (only curiosity 😉 )?

gaearon · 2017-02-10T11:48:08Z

For the future reference, GH always uses PR author when you "Squash and Merge".

Most recent PRs have "allow edits from maintainers" enabled so you should be able to tweak somebody's PR (by fetching their remote and editing and pushing to their branch directly) before merging.

Another way to patch up somebody's PR retaining authorship is to make your own, then manually squash your own commits, leaving one author's and one your own commit, and then "Rebase and Merge" to avoid getting credit for both.

(I learned that by trial and error 😄 )

Timer · 2017-02-10T16:04:38Z

Ah, I assumed GH squash used the first commit author not the PR author.
Also, I forgot the "allow edits from maintainers" was a thing (I started to use that on not-this-PR).

Once again, sorry about this all @EnoahNetzach -- I'll try to be better in the future!

Thanks for the useful tips @gaearon.

…ok#1504) * Add `PUBLIC_URL` env variable for advanced use (facebook#937) * Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host.

@gaearon

* Heroku Deployment: Adds a note on how to resolve "File/Module Not Found Errors" (facebook#1260) * Adds note on how to resolve file or directory not found errors for heroku deployments * Style tweaks * Remove interactive shell check when opening browser on start (facebook#1264) Browser launch can still be suppressed using BROWSER=none * Only gitignore dirs in root, not deep (facebook#1267) * facebookgh-1269: Enabling nested folder paths for project name (facebook#1270) * facebookgh-1269: Enabling nested folder paths for project name * facebookgh-1269: Added "fs-extra" and removed "path-exists" * facebookgh-1269: Added e2e test cases to verify nested folder names * Remove path-exists from dependencies and replace it with fs.existsSync (facebook#1289) * Downgrading to compatible version of SockJS-Client (facebook#1274) * Updated react-scripts babel-jest && jest packages to 18.0.0 (facebook#1311) * Fixes duplicate "is" typo (facebook#1306) * fix readme: remove double 'we' (facebook#1312) * Use npm script hooks to avoid && in deploy script (facebook#1324) * Bump babel-loader version (facebook#1009) (facebook#1309) * Use yarnpkg alias to run Yarn (facebook#1365) There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering. * Use yarnpkg alias to run Yarn (facebook#1365) There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering. * Update changelog for 0.8.5 * Publish - [email protected] - [email protected] * Add missing import in react-dev-utils README.md (facebook#1369) * Change console.log for errors and warnings (facebook#1375) Array.forEach is passed the following parameters: currentValue The current element being processed in the array. index The index of the current element being processed in the array. array - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach console.log takes multiple arguments. We only want to print the first one, the actually message. * webpack-dev-server patch for 'still-ok' success status (facebook#1377) * Document Flow support (facebook#1384) * Document Flow support Projects created by Create React App use the `babel-preset-react` which includes Flow babel plugins which introduces new syntax. This is important for users to know as it causes what used to be syntax errors to be silently suppressed because they're valid type annotations in Flow. For example if a user accidentally has `[foo: 'bar']`, Babel will silently convert it to `[foo]`. * Make it a bit clearer * Use a more sophisticated template for end-to-end testing. (facebook#1187) * Use a more sophisticated template for end-to-end testing. * Not publish integration tests to npm * Use "commander" for cli argv handling * Handle different scripts version forms and exits without a name given * Prepare the commands for testing with a template * Fix dev "template" path * Add various features to test * Test various features separately * Test language features * Comment unused e2e.sh lines * Add "development" tests * Test environment variables * Test webpack plugins * Replace kitchensink README * Switch integration tests from jest to mocha * Use `fs-extra` * Use the correct folders * Do some cleanup * Print a better message for `--template` * Test `npm start` with and without https * Separate fast e2e testing from kitchensink testing * Hide `--internal-testing-template` (former `--template`) CLI option * replace two space syntax with <br> tag (facebook#1393) for consistency :) * Add causes of dev server not detecting changes (facebook#1422) * Add causes of dev server not detecting changes Add causes of `npm start` not detecting changes to Troubleshooting chapter of User Guide * Reworded slightly * Update README.md * Added links to tutorials for integrating cra with an api backend (facebook#1437) * Added Rails link to User Guide * docs: unify sections for rails and node backend integration * docs: fix faulty link and indentation * Added babel-runtime dependency to deduplicate dependencies when using yarn (facebook#1441) * Bump Jest version (facebook#1432) * Readme: Removes experimental from Jest snapshot (facebook#1453) Per final comment in facebook#372 `Snapshot rendering should actually be pretty stable / useable after React 15.4.1. See this post for more info.` * eject: Additionally remove `react-scripts` from dependencies (facebook#1458) ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present. * E2e jsdom fix (facebook#1470) * E2E: run tests when react is ready * Entangle e2e with callbacks * Remove unused e2e lines * - import expect and expect flow (facebook#1463) - code style * Reflect websocket proxy support on README (facebook#1013) (facebook#1483) * Reflect websocket proxy support on README * Add 'the' * Edit User Guide: Add ESLint config for VS Code users (facebook#1482) * Add ESLint config for VS Code users * Update VSC ESLint note to a better solution Update VSC ESLint note to a better solution as discussed in Pull Request * e2e: Reduce complexity of e2e and improve Jest coverage (facebook#1484) * UX: Explain why build is failing (facebook#1352) * Update comments for webpack loaders * Change "OS X" references to "macOS" (facebook#1511) Updated README.md to refer to the current rebranding. * corrected minor typo (facebook#1514) * clarifying the use of custom environment variables (facebook#1513) * clarifying the use of custom environment variables * Tweak * Add missing '\n' to the end of `package.json` file (facebook#1510) * Make all react app vars accessible in index.html (facebook#1440) * Make all vars accessiable in index.html * Fix wrong env provieded to DefinePlugin * Separate results from getClientEnvironment * The `string` should be object instead of string * Fix accessing wrong field * Changed variables naming to `raw` and `stringified` * Remove trailing commas * Add `PUBLIC_URL` env variable for advanced use (facebook#937) (facebook#1504) * Add `PUBLIC_URL` env variable for advanced use (facebook#937) * Add support for `PUBLIC_URL` env variable * Remove unnecessary duplications * Simplify served path choice logic * Honor PUBLIC_URL in development * Add e2e tests Enables serving static assets from specified host. * Support relative asset paths for special case (facebook#1489) * Fix paths in CSS files when homepage is set to "./" In the production build, ExtractTextPlugin is used to generate a separate CSS file instead of injecting style through JavaScript. This plugin does not work well by default with nested output structure. To fix it, we give it a relative publicPath pointing to the build folder. * Add section in README to explain how to make builds deployable anywhere * Apply review requested change * Apply review changes 2 * readme: Add Advanced Configuration (facebook#1515) * Add Advanced Configuration section * Reference package.json instead * Add HOST, HTTPS, and CI * Switch wording from Amazon to a CDN * Add test runner comment * Add top-level README link * Simplify wording * Link to relevant docs * Link to apps * Add .env link * Simpler links * Add a CI flag note * Make build exit with error code when interrupted (facebook#1496) * Make build exit with error code when interrupted This addresses issue facebook#1493. Current behavior is that `npm run build` exits code 0 without creating a bundle when interrupted. This change makes the build script catch catchable interruptions and exit with the appropriate error code. * Better error messages for kill signals * Don't catch SIGINT Ctrl+C should exit silently, and already produces a non-zero exit code when sent to the console while `npm run build` is running. Exit code 0 is produced if SIGINT is sent directly to the `node build.js` process, but this is unlikely to happen. A SIGINT handler in `build.js` will also be triggered by Ctrl+C in the console, potentially producing unnecessary noise. * Style fix * No changes needed to build.js Problem is coming from the parent process, `react-scripts` * Make react-scripts script handle signals * Clarify context * Bump lerna * Add test cases for PUBLIC_URL and relative path (facebook#1519) * Add test cases to evaluate increased CI time * Add positive test cases * Add negative cases * Test default behavior * Exit on failure * Fix test * Add an annoying nit * Upgrade babel dependencies * Don't run CI on Node 0.10 (facebook#1521) * fix: add yarn gitignores (facebook#1507) * fix: add yarn gitignores to template * fix: add yarn gitignores to root * fix: add wildcard to npm-debug.log ignore * Upgrade dependencies (facebook#1522) * Upgrade dependencies * Re-add caret * Add CHANGELOG * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Make index.html interpolation instructions less clashing with env syntax * Add additional info about env variables * Massage 0.9.0 changelog * Add release cutters to changelog * Tweak indentation * Markdown whitespace fixes * Some changelog formatting * Suggest jest-enzyme for simplifying test matchers (facebook#994) * Suggest jest-enzyme for simplifying test matchers * Update README.md * Update README.md * Fix `test -e` with wildcard arguments. (facebook#1503) The `test` command fails with multiple arguments when given a unary operator such as '-e'. Add a function that can test one or more files by looping over all files. * Link to new Sass doc * Clarify Less/Sass support * Add a link to supported features * Add SASS support documentation facebook#1007 (facebook#1008) * Add SASS support documentation facebook#1007 * Change SASS section title to more generic label * Fix link in Table of Contents * Chain build-css with watch-css script, fix typos * Update Sass and Less naming style * Fix wording, remove offensive words * Slightly rewite * [documentation] how to disable autoprefix feature (facebook#1320) * added how to disable autoprefix feature in doc * Just link to the doc * Added link to Azure deployment tutorial (facebook#1338) * Correctly Command in README.md (facebook#1275) * change npm to yarn command * Keep npm primary option * reduxjs/redux#2004 List features beyond ES6 supported by create-react-app (facebook#1313) * reduxjs/redux#2004 List features beyond ES6 supported by create-react-app * Add more info * Update language support wording to ES2017 * Tweak syntax doc (facebook#1539) * Tweak syntax doc * Shorter version * Add useful link to react-scripts (facebook#1495) * Make node version check more robust in e2e.sh (facebook#1295) * Revert "Don't run CI on Node 0.10" (facebook#1547) * Revert "Don't run CI on Node 0.10" * Install after checking node version * Don't use travis install * update CSS preprocessor instructions (facebook#1543) * update CSS preprocessor instructions - Windows shell users should note that running two programs simultaneously is not supported. * fix the order of SASS build step - the suggested build step with integrated CSS preprocessing is wrong. The SASS preprocessor should run first, then the react-scripts build will pick the up-to-date final CSS * Add tweaks from PR discussion * Use Yarn latest in e2e (facebook#1534) * Use Yarn latest in e2e * Here too * And here plz * modified documentation for setting up jest-enzyme (facebook#1562) * Use https in link to Ignoring files at Github (facebook#1561) * add --recursive to sass watch script (facebook#1564) * Mention Windows support explicitly * Reorder * MacOS => macOS * Update README.md (facebook#1573) Update links to jest expect function. * Switch from Neo to Neutrino (facebook#1576) * Switch from Neo to Neutrino * Edited format to be consistent * fixes facebook#1584 PORT env variable not always an integer (facebook#1585) * babel-preset: remove babel-plugin-transform-es2015-parameters (facebook#1598) babel/babel#4851 is closed * Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR (facebook#1608) * Add note for using CHOKIDAR_USEPOLLING in virtual machines to enable HMR * Use br in react-scripts template README md * Use br in md for new line breaks * Update troubleshooting HMR to allow for VMs running Windows * Fix up the instructions * Allow --scripts-version to be a git url (facebook#1570) * Install react, react-dom, and react-scripts at the same time (facebook#1253) * Install react and react-dom along with react-scripts - Install react, react-dom and react-script in a same time - Move react-scripts to devDependencies. * Check if react, react-dom has been already installed - To backward compatibility with old CRA’s cli - In case old CRA doesn’t install react, react-don along with react-scripts * Use packageName to find script dependency - use packageName to find dependency - fix pathExists.sync * Check dependencies.react in package.json instead of actual files * Process exit when dependencies not found - Show error and exit when dependencies not found. - Log install show custom package name * Remove template string * Install dependencies if template is preseted * Remove dangling comma Resolves facebook#1239 * add a comment about NODE_ENV value set to 'production' during build step (facebook#1625) * add a comment about NODE_ENV value set to 'production' during build step facebook#790 (comment) * Move words around * Update flow configuration documentation (facebook#1518) * Update flow configuration documentation The documentation was missing creating the .flowconfig file * Update flow configuration documentation Adding in suggested changes * Wording * Wording * Add note about when to import bootstrap CSS. (facebook#1618) * Add note about when to import bootstrap CSS. * Tweak * Document Sass imports * Fix workflow if react-scripts package is linked via npm-link (facebook#1356) * add npm-link support * - remove extra veriable - simplify condition * update code after review: - remove utils/isReactScriptsLinked - add appPath and ownPath to paths.js (but only for "before eject" export case) * update code after review: - remove utils/isReactScriptsLinked - add appPath and ownPath to paths.js (but only for "before eject" export case) * update code after review: - remove utils/isReactScriptsLinked - add appPath and ownPath to paths.js (but only for "before eject" export case) - remove "if" block for fs.removeSync(ownPath) at ejec.tjs * change ownPath value * Document debugging in the browser. (facebook#1540) * Document debugging in the browser. * Styling * Link to "Debugging in the Editor" * Adding link to “Customizing” create-react-app (facebook#1121) Add documentation for customizing Bootstrap theme * Update index.js (facebook#1603) To avoid file conflict issue with IJ static web projects * Remove .bin files defined at react-scripts/package.json after eject (facebook#1567) * remove bin files after eject defined at package.json * add swallowing try/catch * Bump `recursive-readdir`. (facebook#1560) * Added a how-to on react-snapshot (facebook#1577) * Added a how-to on react-snapshot Added a section with a short description and link to a tutorial on generating static html pages with react-snapshot, and also linked to it from the section on managing the page title. * Updated link title for react-snapshot overview * Explained pre-rendering in a more generic way * Added link to top level README.md, and removed specifics from overview * Updated html -> HTML * Updated quotes and apostrophes * html -> HTML * Fix link * NPM version check for tip (facebook#1193) * Implemented a version check of npm to give a soft tip during the install procedure and fixed gitignore * Moved NPM check to method, it is only executed when you use NPM and the version is < 3. * Minor formatting tweaks * Simplify the code * Remove unnecessary change * Enable eslint caching in development (facebook#1578) * Enable eslint caching in development POC for facebook#740. Haven't found any problem, build times improved about 1s on my project and machine. * Bump eslint-loader to 1.6.3 * move @remove-on-eject block to persist cache config on eject * Use real build path name in build output (facebook#1478) Use the configured appBuild value in paths.js instead of hard-coding it to 'build'. This is helpful for the ejected case where the appBuild path is changed to another folder name. * adding a note on how to resolve "Could not find a required file." dep… (facebook#1391) * adding a note on how to resolve "Could not find a required file." deployment errors because of deleted or ignored files * Tweak * Unrelated style nits * Use posix paths for Jest config during eject (facebook#1635) Resolves facebook#1417 and facebook#1498. * Setting a dynamic port value for the pushstate-server URL text (facebook#1628) * Setting a dynamic port value for the pushstate-server URL text after a build is completed * Fixing merge conflict * Fix up broken line * Gracefully handle initial installation error (facebook#1512) * Gracefully handle initial installation error * Print out message when problem occurs * Delete project folder on errors * Fix directory deleting message Resolves facebook#1505 * Add changelog for 0.9.1 * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Update changelog * Fix npm test on Windows (facebook#1647) * Add 0.9.2 changelog * 0.9.2 * Add a note about known issue * Merge changelogs * Format differently * Set Chrome userDataDir to be under .vscode folder (facebook#1657) * Fix e2e when used with cold cache (facebook#1667) Resolves facebook#1666 * Fix e2e-simple (cont.) * Add appveyor.yml (facebook#1648) * Add appveyor.yml * Execute mocha directly in e2e test * Replace e2e process substitution * Kill nohup node processes after e2e * Disable known failing Windows test * Only build master * fix react dependency versions during initial install (facebook#1669) * fix react dependency versions during initial install * add review remarks * Remove Windows 0.10 simple test * add project name validation (facebook#1662) * add project name validation * Tweak console output * fix project cleanup on windows (facebook#1675) * Revert "Enable eslint caching in development" (facebook#1665) * add X-FORWARDED headers for proxy requests (facebook#1677) * Use offline cached version with yarn when it's possible (facebook#1423) * add --offline flag when we are using yarn and we are offline * Revert changes to init script We only run these commands for backward compat mode, in which we wouldn't receive the offline flag anyway * Don't pass isOnline to init script because it doesn't need it * Don't ping the Yarn registry if user doesn't have Yarn * Remove unused/wrong arguments * Move logs to error handler * Fix error handling * Report to the user that they're offline * Add 0.9.3 changelog (facebook#1683) * Add "migrating" section for 0.9.3 * Publish - [email protected] - [email protected] * False expression should not be in dependencies * Publish - [email protected] * appveyor: Build all branches * Suggest CRA 1.2.1 in changelog * Fixed missing flag in first preprocess command (facebook#1687) * Re-enable e2e-install directory test * Suggest to use .env for enabling polling mode (facebook#1698) * Diagnostic code (facebook#1695) * Adding diagnostic code as requested by @gaearon * Oops * Fix Jest tests for Cygwin * Improve reliability of port hint. (facebook#1696) * fixing things for people with the username `cwd` closes facebook#1694 * combine awk into a single command and add escaping * pin and bump lerna (facebook#1688) * Lerna 2.0.0-beta.38 expects packages entry * Add docs for apache's client side routing setting (facebook#1717) * Add docs for apache's client side routing setting * Tweak advice * Update now.sh deployment instructions. (facebook#1710) * Update now.sh deployment instructions. Incorporates changes announced at https://zeit.co/blog/now-static that streamline Now deployments from CRA projects. * Remove unintentional reference to deployed app. No emergency; just didn't intend to tout or send traffic to my prototype. * Add support for ignoreRestSiblings in no-unused-vars (facebook#1705) * updating eslint to 3.16.1 * add support for ignoreRestSiblings in eslint http://eslint.org/docs/rules/no-unused-vars#ignorerestsiblings * updating eslint to 3.16.1 in `react-scripts` * updating eslint * missing `^` * missing ^ * pinning main eslint and updating readme * Pin ESLint version * add double quotes to escape spaces in paths in e2e (facebook#1707) * add double quotes to escape spaces in path * Change $* to "$@" props to @n3tr * escape spaces in path for all e2e tests * Create appveyor.cleanup-cache.txt * Link Appveyor caches to appveyor.cleanup-cache.txt * Trigger AppVeyor cache cleanup * Fix hot reloading for WebpackDevServer after eject (facebook#1721) * Fix openBrowser() when BROWSER=open on macOS (facebook#1690) * Fix openBrowser() when BROWSER=open on macOS * Tweaks * Create empty package.json in e2e test (facebook#1401) (facebook#1402) * Create empty package.json in e2e test Create empty package.json in e2e test while installing packaged CLI to prevent installation issues. * Use "npm init" to initialize package.json instead of just writing an empty object into it. * Fix typo * Skip AppVeyor CI builds for Markdown changes (facebook#1723) * Skip CI builds for Markdown changes * I will never learn YML * Don't use ES6 in a file that should run on Node 4 (facebook#1724) * Bump jsx-a11y version (facebook#1542) * Bump jsx-a11y version * Update package dependecy for jsx-a11y * Bump version in react-scripts * Bump ESLint config to 0.6.0 manually * Fix Node 4 e2e tests (facebook#1730) * Lint internal scripts with eslint:recommended (facebook#1729) * Lint internal scripts with eslint:recommended * Warnings r bad * Fix ejecting from a scoped fork (facebook#1727) * Read script names from own bin instead of guessing This fixes ejecting from a fork that uses a different bin script name. * Fix ejecting for a scoped react-scripts fork We shouldn't hardcode react-scripts because fork name might differ. We also shouldn't rely on it being an immediate child because scoped packages are a level deeper. * Clarify that own* properties only exist before ejecting * Properly extract package name for installing tgz of scoped packages (facebook#1706) * Properly extract package name * Download package if need be ... * Oops * Add e2e test based on facebook#1537, but without specific filename * Pass packageName through promises A little bit more verbose but explicit and doesn't rely on shared mutable state. * Fix up directory name in test * Tweak failure message * Fix lint * extract generic build functions to react-dev-utils (facebook#1726) * Temp rename * Rename to change the case * extract generic build functions to react-dev-utils * tweak package json files and move removeFileNameHash * revert removeFileNameHash * use paths.appBuild in printFileSizes * use paths.appBuild in removeFileNameHash * change curried functions to regular functions * add fs-extra to react-dev-utils deps * move getDifferenceLabel inside printFileSizes * inline copyPublicFolder * combine printFileSizes and removeFileNameHash to fileSizeReporter * fix typo * Tweak APIs and fix issues * Fix heading * Remove missing file * Newline * Newline * Trailing space * Update FileSizeReporter.js * Update build.js * Bust AppVeoyr cache * Relax ESLint config peerDependency (facebook#1740) * Fix internal linting setup and add missing headers (facebook#1741) * Fix lint * Fix eject for linked react-scripts (facebook#1736) * fix eject for linked react-scripts * path.resolve => resolveApp * Add changelog for 0.9.4 * Publish - [email protected] - [email protected] - [email protected] - [email protected] * Adjust changelog wording * Switch to preset-env (facebook#1742) * Switch to preset-env Disables webpack modules by enabling babel modules to resolve facebook#1638 * Bump babel-core to match babel preset versions * Add uglify to targets * Display yarn instead of yarnpkg when creating a new app (facebook#1747) * Display yarn instead of yarnpkg * Refactored displayd commands * Removed testing directory * Add yarn steps for adding flow (facebook#1756) [skip ci] * Suggest `serve` for running in production (facebook#1760) * Suggest `serve` for serving the `build` directory * How to handle it with Node in prod (or other platforms) * Pretty newline added * Adjusted default port of static server * Remove `open` command from output * Removed constant assignment * Better explanation for not using having to use a static server * Cute newline added * Style nits * Remove 'guard-for-in' lint rule (facebook#1773) Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule? * Run CI on Node 7; Bump detect-port: 1.0.1 -> 1.1.0 (facebook#1776) (facebook#1783) * Run CI on Node 7 * Bump detect-port: 1.0.1 -> 1.1.0 * Run AppVeyor CI on Node 7 * Add 0.9.5 changelog (facebook#1784) * Add 0.9.5 changelog * Update CHANGELOG.md * Publish - [email protected] - [email protected] - [email protected] * docs(babel-preset): Update comment info about babel-preset-env. (facebook#1787) * Feature/readme-nomoretools (facebook#1799) * docs: replace TDLR with a meaningful heading * docs: insert section No additional build tools * Tweak wording * Suggest "yarn build" rather than "yarn run build" (facebook#1800) * Fix for issue facebook#1798: Suggested 'yarn build' versus 'yarn run build' * remove 'run' from 'yarn test' command as well * conditionally show 'run' if Yarn is not available * Tweak the wording * Allow creation of apps in empty mercurial repos (facebook#1811) * Allow creation of apps in empty mercurial repos * Adding .hgignore to list of validFiles for isSafeToCreateProjectIn check * Adding .hgcheck to list of validFiles for isSafeToCreateProjectIn check * Link to CRNA * Make Surge guide more focused * User Guide: Removed blockquote from code section, due to markdown conflict (facebook#1869) * Removed blockquote from code section * Fix the fix * Fix AppVeyor CI (facebook#1876) * Fix responsive behavior in iOS 9+ (facebook#1821) * Adding shrink-to-fit=no for proper responsive handling on Safari 9+ * Check internet connectivity with lookup instead of resolve (facebook#1863) Resolves facebook#1818 * Update `detect-port` (facebook#1861) Previous changes caused `detect-port` to pick random port on app startup. Update fixes this regression, `detect-port` pick next available port instead. * Fix importing linked packages (facebook#1884) Resolves facebook#1661 * Fix AppVeyor CI (facebook#1868) * Fix AppVeyor CI (facebook#1876) * Run AppVeyor on Visual Studio 2017 * Suggest Yarn in HTML template (facebook#1911) * Fix npm to yarn * yarn & npm * Update index.html * Switch ordering of suggestion We should suggest NPM first for new users. * Note that only [email protected] is compatible * Add sku to the list of alternatives (facebook#1962) * Update information in User Guide for Enzyme dependency (facebook#1982) * Ensure proxy url starts with `http://` or `https://` (facebook#1890) * Update ansi-html to fix facebook#1881 * Add linked modules test (0.9.x) (facebook#1912) * Add linked modules test * Keep fallback after eject * Add note about installing watchman (facebook#1950) * Add note about installing watchman * Update CONTRIBUTING.md * Start the dev server at the specified host Pass the host from environment variable as argument of the devServer's listen function instead of a field of options object. Set the default host to 0.0.0.0 instead of localhost. * Add folder structure docs for new contributors (facebook#1991) * Adding folder structure to help people navigate through project. It helps in resolving issues by providing brief description of each package and its purpose * Removing unnecessary packages from Folder structure heading * Update CONTRIBUTING.md * Relax label rules (facebook#1989) # Conflicts: # packages/eslint-config-react-app/index.js * Update doc server example to work from any directory (facebook#1988) * Node.js serving with absolute path It’s safer to use the absolute path of the directory that you want to serve, in case you run the express app from another directory. * Update README.md * Fix config discrepancies after merging from upstream v0.9.x * Minor fixes per feedback for upstream merging * Fix import from incorrect module * Release v7.0.0

facebook-github-bot added the CLA Signed label Oct 20, 2016

dapids suggested changes Oct 21, 2016

View reviewed changes

gaearon reviewed Oct 28, 2016

View reviewed changes

gaearon added this to the 0.8.0 milestone Oct 28, 2016

EnoahNetzach mentioned this pull request Nov 2, 2016

Dynamically fill in "homepage" in package.json with environment varaiables #998

Closed

andreypopp approved these changes Nov 2, 2016

View reviewed changes

jjasonclark mentioned this pull request Nov 5, 2016

Applications served from cdn on different host #647

Closed

gaearon mentioned this pull request Nov 8, 2016

Relative paths in build output #165

Closed

EnoahNetzach force-pushed the master branch from 217314a to ce7d54c Compare November 21, 2016 10:34

EnoahNetzach force-pushed the master branch from ce7d54c to c403dd5 Compare November 25, 2016 00:48

EnoahNetzach mentioned this pull request Nov 25, 2016

Image: new babel/webpack loader necolas/react-native-web#237

Closed

existentialism mentioned this pull request Dec 1, 2016

Make PUBLIC_URL environment variable available at build time. #1128

Closed

Enoah Netzach and others added 5 commits January 31, 2017 12:07

Add support for PUBLIC_URL env variable

7add7ae

Remove unnecessary duplications

3b1563e

Simplify served path choice logic

12f64d1

Honor PUBLIC_URL in development

511d1c4

Add e2e tests

40a8788

EnoahNetzach force-pushed the master branch from 6cc8fd3 to 40a8788 Compare January 31, 2017 17:21

gaearon mentioned this pull request Feb 4, 2017

Is there any way to set homepage outside of package.json? #1435

Closed

Timer mentioned this pull request Feb 8, 2017

Release 0.9.0 #1430

Closed

Timer mentioned this pull request Feb 9, 2017

Add PUBLIC_URL env variable for advanced use (#937) #1504

Merged

Timer closed this Feb 10, 2017

This was referenced Feb 10, 2017

Cannot serve built static assets from external CDN #936

Closed

Add test cases to validate functionality of PUBLIC_URL and relative homepage #1516

Closed

Timer mentioned this pull request Feb 10, 2017

Allow more customization to homepage option #1279

Closed

Timer mentioned this pull request Mar 31, 2017

serve bundles and app under homepage path #1887

Closed

gaearon mentioned this pull request Jan 8, 2018

Using the script directly breaks assets #3708

Closed

lock bot locked and limited conversation to collaborators Jan 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `PUBLIC_URL` env variable #937

Add support for `PUBLIC_URL` env variable #937

EnoahNetzach commented Oct 20, 2016

dapids Oct 21, 2016

lexfrl commented Oct 21, 2016

mars commented Oct 22, 2016

gaearon left a comment

gaearon Oct 28, 2016

gaearon Oct 28, 2016

EnoahNetzach Oct 28, 2016

gaearon Oct 28, 2016

andreypopp Nov 2, 2016

EnoahNetzach Nov 3, 2016 •

edited

Loading

JSONRice Jun 4, 2018

gaearon commented Nov 3, 2016

gaearon commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

gaearon commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

andreypopp commented Nov 3, 2016

gaearon commented Nov 3, 2016

gaearon commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

jjasonclark commented Nov 5, 2016

EnoahNetzach commented Nov 6, 2016

gaearon commented Nov 20, 2016

EnoahNetzach commented Nov 21, 2016

EnoahNetzach commented Nov 25, 2016

fson commented Nov 26, 2016

Timer commented Feb 10, 2017 •

edited

Loading

EnoahNetzach commented Feb 10, 2017

gaearon commented Feb 10, 2017

Timer commented Feb 10, 2017

		var homepagePathname = homepagePath ? url.parse(homepagePath).pathname : '/';
		var servedPath = process.env.PUBLIC_URL ? homepagePath : homepagePathname;

Add support for PUBLIC_URL env variable #937

Add support for PUBLIC_URL env variable #937

Conversation

EnoahNetzach commented Oct 20, 2016

dapids Oct 21, 2016

Choose a reason for hiding this comment

lexfrl commented Oct 21, 2016

mars commented Oct 22, 2016

gaearon left a comment

Choose a reason for hiding this comment

gaearon Oct 28, 2016

Choose a reason for hiding this comment

gaearon Oct 28, 2016

Choose a reason for hiding this comment

EnoahNetzach Oct 28, 2016

Choose a reason for hiding this comment

gaearon Oct 28, 2016

Choose a reason for hiding this comment

andreypopp Nov 2, 2016

Choose a reason for hiding this comment

EnoahNetzach Nov 3, 2016 • edited Loading

Choose a reason for hiding this comment

JSONRice Jun 4, 2018

Choose a reason for hiding this comment

gaearon commented Nov 3, 2016

gaearon commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

gaearon commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

andreypopp commented Nov 3, 2016

gaearon commented Nov 3, 2016

gaearon commented Nov 3, 2016

EnoahNetzach commented Nov 3, 2016

jjasonclark commented Nov 5, 2016

EnoahNetzach commented Nov 6, 2016

gaearon commented Nov 20, 2016

EnoahNetzach commented Nov 21, 2016

EnoahNetzach commented Nov 25, 2016

fson commented Nov 26, 2016

Timer commented Feb 10, 2017 • edited Loading

EnoahNetzach commented Feb 10, 2017

gaearon commented Feb 10, 2017

Timer commented Feb 10, 2017

Add support for `PUBLIC_URL` env variable #937

Add support for `PUBLIC_URL` env variable #937

EnoahNetzach Nov 3, 2016 •

edited

Loading

Timer commented Feb 10, 2017 •

edited

Loading