Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shortlinks to cra.link #8957

Merged
merged 2 commits into from
May 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docusaurus/docs/making-a-progressive-web-app.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ following in their [`src/index.js`](https://github.com/facebook/create-react-app
```js
// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
// Learn more about service workers: https://cra.link/PWA
serviceWorker.unregister();
```

Expand Down
2 changes: 1 addition & 1 deletion packages/cra-template-typescript/template/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ ReactDOM.render(

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
// Learn more about service workers: https://cra.link/PWA
serviceWorker.unregister();
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// resources are updated in the background.

// To learn more about the benefits of this model and instructions on how to
// opt-in, read https://bit.ly/CRA-PWA
// opt-in, read https://cra.link/PWA

const isLocalhost = Boolean(
window.location.hostname === 'localhost' ||
Expand Down Expand Up @@ -51,7 +51,7 @@ export function register(config?: Config) {
navigator.serviceWorker.ready.then(() => {
console.log(
'This web app is being served cache-first by a service ' +
'worker. To learn more, visit https://bit.ly/CRA-PWA'
'worker. To learn more, visit https://cra.link/PWA'
);
});
} else {
Expand Down Expand Up @@ -79,7 +79,7 @@ function registerValidSW(swUrl: string, config?: Config) {
// content until all client tabs are closed.
console.log(
'New content is available and will be used when all ' +
'tabs for this page are closed. See https://bit.ly/CRA-PWA.'
'tabs for this page are closed. See https://cra.link/PWA.'
);

// Execute callback
Expand Down
2 changes: 1 addition & 1 deletion packages/cra-template/template/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ ReactDOM.render(

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
// Learn more about service workers: https://cra.link/PWA
serviceWorker.unregister();
6 changes: 3 additions & 3 deletions packages/cra-template/template/src/serviceWorker.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// resources are updated in the background.

// To learn more about the benefits of this model and instructions on how to
// opt-in, read https://bit.ly/CRA-PWA
// opt-in, read https://cra.link/PWA

const isLocalhost = Boolean(
window.location.hostname === 'localhost' ||
Expand Down Expand Up @@ -43,7 +43,7 @@ export function register(config) {
navigator.serviceWorker.ready.then(() => {
console.log(
'This web app is being served cache-first by a service ' +
'worker. To learn more, visit https://bit.ly/CRA-PWA'
'worker. To learn more, visit https://cra.link/PWA'
);
});
} else {
Expand Down Expand Up @@ -71,7 +71,7 @@ function registerValidSW(swUrl, config) {
// content until all client tabs are closed.
console.log(
'New content is available and will be used when all ' +
'tabs for this page are closed. See https://bit.ly/CRA-PWA.'
'tabs for this page are closed. See https://cra.link/PWA.'
);

// Execute callback
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dev-utils/printBuildError.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = function printBuildError(err) {
} catch (ignored) {
console.log('Failed to minify the bundle.', err);
}
console.log('Read more here: https://bit.ly/CRA-build-minify');
console.log('Read more here: https://cra.link/failed-to-minify');
} else {
console.log((message || err) + '\n');
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-dev-utils/printHostingInstructions.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function printHostingInstructions(
console.log();
console.log('Find out more about deployment here:');
console.log();
console.log(` ${chalk.yellow('create-react-app.dev/docs/deployment')}`);
console.log(` ${chalk.yellow('https://cra.link/deployment')}`);
console.log();
}

Expand Down
4 changes: 1 addition & 3 deletions packages/react-scripts/scripts/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,7 @@ module.exports = function(
'This template should be updated to use the new `package` key.'
)
);
console.log(
'For more information, visit https://create-react-app.dev/docs/custom-templates'
);
console.log('For more information, visit https://cra.link/templates');
}
if (templateJson.dependencies) {
templatePackage.dependencies = templateJson.dependencies;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/scripts/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ if (process.env.HOST) {
`If this was unintentional, check that you haven't mistakenly set it in your shell.`
);
console.log(
`Learn more here: ${chalk.yellow('https://bit.ly/CRA-advanced-config')}`
`Learn more here: ${chalk.yellow('https://cra.link/advanced-config')}`
);
console.log();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Learn about making a Progressive Web App [here](https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old README actually has 6 different links on it that were referenced by old bitly links so replacing this with a link to one of them doesn't really work.

This file has moved [here](https://github.com/facebook/create-react-app/blob/master/packages/cra-template/template/README.md)