hotfix about find the custom template path.

[ricardoamedeiros]

Hi,
It is a pleasure to contribute to the community and to the fantastic ReactJS framework.

This correct is about the issue #8425 and #8844 . In issue #8425 I detail the problem and the applied solution.

[facebook-github-bot]

Hi @ricardoamedeiros!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[abdusco]

any chance this gets merged?

[mrmckeb]

Hi @ricardoamedeiros, can you share an example template for me to test with? You can message me privately if that's better - otherwise I can't verify this fix.

[ricardoamedeiros]

Hi @ricardoamedeiros, can you share an example template for me to test with? You can message me privately if that's better - otherwise I can't verify this fix.

I can. Do you prefer a video call? I am portuquese, but we can to try.

[ricardoamedeiros]

Hi @ricardoamedeiros, can you share an example template for me to test with? You can message me privately if that's better - otherwise I can't verify this fix.

This is my cra-template:

cra-template-sebrae.zip

error:

After the correction I applied to the "react-script" it worked:

[mrmckeb]

Hi @ricardoamedeiros, the issue you're trying to fix here has actually already been fixed - but not released yet.

Until our next release, you need to have a main field in your template's package.json, which is required by require.resolve.

You can see the commit where we fixed that here:
e0b179c#diff-1453d9590326c639309801105bc967c2

Can you please test adding the main field and confirm that it works? Thanks!

[abdusco]

I've been able to use private scoped template @org/cra-template-qwerty using the solution here

solution: just add

{
  "main": "template.json"
}

in package.json

[ricardoamedeiros]

Hi @ricardoamedeiros, the issue you're trying to fix here has actually already been fixed - but not released yet.

Until our next release, you need to have a main field in your template's package.json, which is required by require.resolve.

You can see the commit where we fixed that here:
e0b179c#diff-1453d9590326c639309801105bc967c2

Can you please test adding the main field and confirm that it works? Thanks!

@abdusco

{
"main": "template.json"
}

It worked. Thanks.