Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack to improve performance #7740

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Update webpack to improve performance #7740

merged 2 commits into from
Sep 30, 2019

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Sep 26, 2019

Speeds up the process.

Webpack changelogs

  • disallow cache group named test with shorthand syntax to point out a potential config error
  • Improve performance of LimitChunkCountPlugin
  • fix a bug that the HMR plugin affected child compilations
  • improve performance of splitChunks name option by caching hashed value
  • improve rebuild performance by caching module size computation

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 27, 2019

I'm OK with this, but we're getting a lot of CI failures here - it completely fails on Windows.

Re-running checks ;)

@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 27, 2019

@ianschmitz any thoughts on why these are failing? I assume a simple Webpack version bump wouldn't be the issue...

@ianschmitz
Copy link
Contributor

@ianschmitz any thoughts on why these are failing? I assume a simple Webpack version bump wouldn't be the issue...

Appears to be failing on master as well. Doesn't appear to be related to this PR. Bah silly Windows!

@mrmckeb mrmckeb merged commit 4a3718b into facebook:master Sep 30, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 30, 2019

Thanks for your help @RDIL!

And @ianschmitz, let's talk about this during the week. I think a lot of the tests could do with some love anyway.

@RDIL RDIL deleted the patch-1 branch September 30, 2019 11:17
@lock lock bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants