enable .eslintignore again

[igtm]

This line of code has been added by this PR.

But I cannot understand why react-script doesn't support the essential config file of eslint.

I'd say that it should be needed for some cases such as ignoring generated files or something like that.

This topic about .eslintignore has been discussed as follows

• doesn't respect .eslintignore #2339
• Cannot use .eslintignore for generated files #7339

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[igtm]

I signed up just now!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[silverwind]

Maybe only enable it when EXTEND_ESLINT=true?

[nickserv]

I'd love to have this merged. It's frustrating that trying to use a strict ESLint config on my own code causes unnecessary warnings on generated files that shouldn't be modified, and it prevents me from using EXTEND_ESLINT=true.

[ianschmitz]

@mrmckeb any concerns with this one having done the eslint config work?

[ianschmitz]

Maybe only enable it when EXTEND_ESLINT=true?

That could be a good idea. I guess the question is should we support this file even if the user isn't modifying our OOTB lint config?

[nickserv]

I think it would be more consistent to only respect the ESLint ignore if EXTEND_ESLINT=true, since without this variable an ESLint config is ignored, and ESLint ignores often accompany ESLint configs.

[mrmckeb]

@igtm We think we can get this into our 3.2 release, but it needs to be behind the flag EXTEND_ESLINT=true for now.

Can you make that change?

[igtm]

I'm sorry for the late reply.
I changed the code so that it can be enabled only when EXTEND_ESLINT is true