Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installing-a-dependency.md #6408

Closed
wants to merge 1 commit into from
Closed

Update installing-a-dependency.md #6408

wants to merge 1 commit into from

Conversation

shiraze
Copy link

@shiraze shiraze commented Feb 12, 2019

The "--save" option has not been needed since the release of npm 5.0.0 (released 26 May 2017)

The "--save" option has not been needed since the release of npm 5.0.0 (released 26 May 2017)
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@amyrlam
Copy link
Contributor

amyrlam commented Feb 21, 2019

Thanks for the PR! There still seems to be a lot of traction in the gist linked for pre-npm 5 versions. So in this case, I think we should leave --dev for those still using an older version of npm.

@amyrlam amyrlam self-requested a review February 22, 2019 05:17
@amyrlam
Copy link
Contributor

amyrlam commented Feb 23, 2019

Closing for now but maybe can revisit more npm-related stuff in the future.

@amyrlam amyrlam closed this Feb 23, 2019
@lock lock bot locked and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants