Sass source map for dev

[alicialics]

#5707

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[bugzpodder]

I tested this and it looks great. Thank you!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[ianschmitz]

Shouldn't style-loader have sourceMap enabled as well?

https://github.com/postcss/postcss-loader#sourcemap
https://github.com/webpack-contrib/style-loader#options

[bugzpodder]

cc @Fabianopb
According to https://github.com/webpack-contrib/sass-loader#source-maps it didn't say it was needed on style-loader. this set of changes on dev is consistent with the config on prod, I would imagine that it should be added two both configs if deemed necessary.

[Fabianopb]

It's been many months, but I had in my mind that it wasn't necessary to enable sourceMap in style-loader because I remember seeing this documentation that @bugzpodder referenced here.

But, not sure now, as @ianschmitz noticed from the style-loader docs, it seems to be required.

Apparently we have conflicting information, should we ask someone from webpack-contrib to confirm?

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[bugzpodder]

@zhuoli99 Can you rebase this diff with the latest webpack config changes? Thanks!