Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Swap paywalled tutorial for free tutorial #5028

Closed
wants to merge 1 commit into from

Conversation

imgntn
Copy link
Contributor

@imgntn imgntn commented Sep 18, 2018

In the "Storybook" section

It doesn't seem right to send people toward a paywalled resource when there are free ones available.

I put in the first Youtube result which is a free tutorial by the same name from FullStack Academy, but I'm also in favor of replacing this link with a Youtube search for the term.

https://www.youtube.com/results?search_query=getting+started+with+react+storybook

capture
capture2

It doesn't seem right to send people toward a paywalled resource when there are free ones available.

I put in the first Youtube result which is a free tutorial by the same name from FullStack Academy, but  I'm also in favor of replacing this link with a Youtube search for the term.    

```https://www.youtube.com/results?search_query=getting+started+with+react+storybook```
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@imgntn imgntn changed the title Update README.md Update README.md - Swap paywalled tutorial for free tutorial Sep 18, 2018
@Timer
Copy link
Contributor

Timer commented Sep 18, 2018

That's not cool! We didn't know this was behind a paywall.

Is this the best free resource? Is there something more succinct?

@imgntn
Copy link
Contributor Author

imgntn commented Sep 18, 2018

Hard to compare to the content its replacing since its behind the paywall, but:

This video is more of an overview of what Storybook does and why - medium length
https://www.youtube.com/watch?v=E2c183LS4lA&t=1s

This video is more specifically about how to put Storybook into Create React App - short
https://www.youtube.com/watch?v=va-JzrmaiUM

This is a great thorough intro from the Facebook developers channel - long
https://www.youtube.com/watch?v=PF0Vi-iIyoo

Inevitably any kind of video-based intro will become outdated, so I'm not totally sure about the usefulness of specific video links (although at least you can tell by the uploaded date whether it IS outdated, unlike a lot of web pages).

@Timer
Copy link
Contributor

Timer commented Sep 18, 2018

Hm, do they have a getting started guide we can link to instead?

@imgntn
Copy link
Contributor Author

imgntn commented Sep 18, 2018

The storybook docs you link below are pretty good, maybe just remove the video link altogether?

Here's another nice alternative https://www.learnstorybook.com/

@Timer
Copy link
Contributor

Timer commented Sep 19, 2018

I like that link, let's replace it with that and update the caption.

@Timer
Copy link
Contributor

Timer commented Sep 19, 2018

Also, please send this PR against next, not master, thanks!

@imgntn imgntn closed this Sep 19, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants